From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AAAB646381 for ; Thu, 15 Jun 2023 13:57:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 53CF768C3B6; Thu, 15 Jun 2023 16:57:26 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D8BDD68C2F4 for ; Thu, 15 Jun 2023 16:57:19 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 7A3F31060229 for ; Thu, 15 Jun 2023 13:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1686837438; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=b+dmkPH6TmcO7Sy9sss/KW60ExGeVLx+NvsZiQhiW9o=; b=QRYcl3vxDb61Gpo+ZHjCU3FS0W4SuWt1dyl8hYBRTr0jjbTWyiIVv33tr9rqLWm8 GQxDFiB9wnV/TElQBCujg9iZLFthfLctELRxA4UO/AlpWlloRKGnTQNQp4NNIiFfxBP OB2pciXdbPFShcuvHmbzR2XhPCwOYKDrncCTyz9F4cTFzN7PTrRdJ6JySOtiXarBZ2u VVjLkbY4cjKodcnYkLA8LtUy/JLGkJhSOIctSe3VrwTOCgkBFwVLsoxm5Zgtx76hYkv lty2TB17cxdputovKRkp6eh+3bBu3WJ2HwqTO81U0iDjxtWbE1b4GV3j5+0wzkSoeaq mUpvfo3QeQ== Date: Thu, 15 Jun 2023 15:57:18 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20230615103645.25778-1-shenpeiting@eswincomputing.com> References: <20230615103645.25778-1-shenpeiting@eswincomputing.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 0/6] RISC-V initial ac3dsp X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jun 15, 2023, 12:37 by shenpeiting@eswincomputing.com: > From: Shen Peiting > > We optimized the six interfaces of AC3 init by RVV, the optimized > performance was tested on the RISC-V ISA simulator--Spike, and the > results were attached to each commit. > > shenpeiting (6): > lavc/ac3dsp: RISC-V V ac3_exponent_min > lavc/ac3dsp: RISC-V V float_to_fixed24 > lavc/ac3dsp: RISC-V V ac3_sum_square_butterfly_int32 > lavc/ac3dsp: RISC-V V ac3_sum_square_butterfly_float > lavc/ac3dsp: RISC-V V ac3_compute_mantissa_size > lavc/ac3dsp: RISC-V B ac3_extract_exponents > > libavcodec/ac3dsp.c | 2 + > libavcodec/ac3dsp.h | 1 + > libavcodec/riscv/Makefile | 3 + > libavcodec/riscv/ac3dsp_init.c | 60 +++++++++ > libavcodec/riscv/ac3dsp_rvb.S | 42 ++++++ > libavcodec/riscv/ac3dsp_rvv.S | 225 +++++++++++++++++++++++++++++++++ > 6 files changed, 333 insertions(+) > create mode 100644 libavcodec/riscv/ac3dsp_init.c > create mode 100644 libavcodec/riscv/ac3dsp_rvb.S > create mode 100644 libavcodec/riscv/ac3dsp_rvv.S > Could you implement checkasm for this? It shouldn't be more than a hundred lines, and there are examples, tests/checkasm/aacpsdsp.c being the most similar. Since CPUs with the needed extensions aren't released, we're not doing any FATE runs, and so if the results don't match the C version, we'll end up with broken code once they do exist. And no one wants to debug someone else's assembly. Those results look far too optimistic, and I'm guessing it's because they're using a theoretical huge vector size limit. Could you re-test with something more realistic, like 256-bit vectors, using checkasm --bench? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".