Re: [FFmpeg-devel] [PATCH] pthread_frame: uninit the hwaccel of each frame thread

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] pthread_frame: uninit the hwaccel of each frame thread
Date: Wed, 14 Jun 2023 18:39:42 +0200 (CEST)
Message-ID: <NXuljea--3-9@lynne.ee> (raw)
In-Reply-To: <NXmWSIQ--3-9@lynne.ee-NXmWWXY----9>

Jun 13, 2023, 04:11 by dev@lynne.ee:

> The issue is that with a threadsafe hwaccel and multiple enabled
> frame threads, hwaccel->uninit() is never called.
> Previously, the function was guaranteed to never have any threads
> with hwaccel contexts, so it never bothered to uninit it.
>
> Patch attached.
>
> ---
> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c
> index 28335231fd..bdc1718ab3 100644
> --- a/libavcodec/pthread_frame.c
> +++ b/libavcodec/pthread_frame.c
> @@ -751,6 +751,8 @@ void ff_frame_thread_free(AVCodecContext *avctx, int thread_count)
>              if (codec->close && p->thread_init != UNINITIALIZED)
>                  codec->close(ctx);
>  
> +            ff_hwaccel_uninit(ctx);
> +
>              if (ctx->priv_data) {
>                  if (codec->p.priv_class)
>                      av_opt_free(ctx->priv_data);
> -- 
>

Ping. Tested it, haven't had issues with this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".