From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 82D2B46000
	for <ffmpegdev@gitmailbox.com>; Mon, 29 May 2023 01:33:03 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 00F8E68C1F5;
	Mon, 29 May 2023 04:33:00 +0300 (EEST)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 73F6668B157
 for <ffmpeg-devel@ffmpeg.org>; Mon, 29 May 2023 04:32:54 +0300 (EEST)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 57DD51060160
 for <ffmpeg-devel@ffmpeg.org>; Mon, 29 May 2023 01:32:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1685323973; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=n2NkIAyr63hCvfZ7FpQSFAJxXnIBtRLW/dMuwcl5LB0=;
 b=4bwS5V7sTmc2OT22y/qbzsfsXSSkEJZ0MRxTFDn7BOM64rCpD8co68unrPPLyExr
 pMr7Ck5QzAT3gEvkIxMXGO2Avh+gkQ8GvBXRff7sI8Gu0uEKtj5foesJITY7NKfGDqt
 lftylg7EWdERvsfPECMi/C2QqN1U4Td2bZsf/DPpGjvUKR3bbHT7NAlrZSPWHPDnJQc
 SqC7OZj7orluc8ZLvyWbyhgyTJBEiQPmu/TslNyJd0gjNEc5TpJIhOmi4r3DeUzrtQF
 tUZXPk2bbKGuao80une60u4bMps8BD9RxlJ21ZfWgPt/kIf1nY1T42fALXjEmFW/0aO
 DZoetE4m4A==
Date: Mon, 29 May 2023 03:32:53 +0200 (CEST)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <NW_7k9M--3-9@lynne.ee>
In-Reply-To: <20230528182037.1e906329@fido7>
References: <NWZse6z--3-9@lynne.ee> <20230528182037.1e906329@fido7>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] vulkan_decode: check if yuv_sampler
 exists before freeing it
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/NW_7k9M--3-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

May 29, 2023, 03:20 by philipl@overt.org:

> On Mon, 29 May 2023 02:22:34 +0200 (CEST)
> Lynne <dev@lynne.ee> wrote:
>
>> No Vulkan function is NULL-safe, for no real reason, despite
>> the language defining and returning VK_NULL_HANDLE.
>>
>> Patch attached.
>>
>
> Tested and works. I will note that both the function and s->hwctx are
> null in the failure case and if ctx->sampler could exist without those
> also being non-null, you could segfault again. I assume this won't
> happen in practice.
>
> ship it.
>

Pushed with a better description of what it fixes.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".