From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] vulkan_decode: check if yuv_sampler exists before freeing it
Date: Mon, 29 May 2023 03:32:53 +0200 (CEST)
Message-ID: <NW_7k9M--3-9@lynne.ee> (raw)
In-Reply-To: <20230528182037.1e906329@fido7>
May 29, 2023, 03:20 by philipl@overt.org:
> On Mon, 29 May 2023 02:22:34 +0200 (CEST)
> Lynne <dev@lynne.ee> wrote:
>
>> No Vulkan function is NULL-safe, for no real reason, despite
>> the language defining and returning VK_NULL_HANDLE.
>>
>> Patch attached.
>>
>
> Tested and works. I will note that both the function and s->hwctx are
> null in the failure case and if ctx->sampler could exist without those
> also being non-null, you could segfault again. I assume this won't
> happen in practice.
>
> ship it.
>
Pushed with a better description of what it fixes.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-29 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 0:22 Lynne
2023-05-29 1:20 ` Philip Langdale
2023-05-29 1:32 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NW_7k9M--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git