From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BB46C453BD for ; Sun, 28 May 2023 23:38:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB5C968C1F5; Mon, 29 May 2023 02:38:11 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C7B6C68C0C7 for ; Mon, 29 May 2023 02:38:04 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id DB119106015D for ; Sun, 28 May 2023 23:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1685317084; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=FNks4mMAAnWdnJqCMk3ZEX7RcDEtvacgjkt1Yljs6lY=; b=jPcX8VwNHvmOW7ZXhLL5lPPj1+fyTAeh1YlK+cT8LkVwIEKppZalUbJs0RjuystQ qHgLLXk4LI+gbajMV7wmLisJbnY4xZx3pTpnDkNb8b14UGntlIH5JaTlMH+vhGHdgRx rHnyu82EbY20tBuri+O5OGXJYlcJrwYMsJdQd360LPV072VWiMI75fPtkH4fgkODKRY aD4L6yQEcGNtCabiZAwZ7OuV6U/x6majnnZfG/i3yLxXw046cPRoE9Rjeeofu9AcYn3 CREY8G02MKZc3Z8trdQQXnCpNb8ACtpjQu8hoBFtq7IdIllprpBrXU2ci4/ttfnATOd 9FkJI4y0bA== Date: Mon, 29 May 2023 01:38:04 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <666c0b52-c122-d707-e392-a35d7a354f15@gmail.com> References: <666c0b52-c122-d707-e392-a35d7a354f15@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] doc/filtering: document some Vulkan filters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 29, 2023, 00:57 by jamrial@gmail.com: > On 5/28/2023 7:55 PM, Lynne wrote: > >> May 28, 2023, 17:54 by dev@lynne.ee: >> >>> This commit documents some of the Vulkan filters. Some of this was >>> copy-pasted from equivalent OpenCL filters. >>> >> >> Pushed alongside the Vulkan patchset. >> > > Were all 100 patches reviewed and approved? > As far as I can tell. Niklas has taken a look at them and given his LGTM.elenril reviewed all patches up to and including the common video decoding code. There was an issue with internal_ref, but internal_ref turned out to be unneeded. I had a "okay then" after "any other hidden API changes" which I interpreted as at least any public-side changes and code up to common video decoding being good. What was left - the codec files themselves, are not doing anything other than copying struct values and calling the common video decoding functions. The patchset has been here in various forms since February, in a stable form since April, in its current form, minus a few cleanups and documentation since last week, and in its final form, since late Friday, with many calls for reviews. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".