Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] doc/filtering: document some Vulkan filters
Date: Mon, 29 May 2023 01:38:04 +0200 (CEST)
Message-ID: <NWZiTGO--3-9@lynne.ee> (raw)
In-Reply-To: <666c0b52-c122-d707-e392-a35d7a354f15@gmail.com>

May 29, 2023, 00:57 by jamrial@gmail.com:

> On 5/28/2023 7:55 PM, Lynne wrote:
>
>> May 28, 2023, 17:54 by dev@lynne.ee:
>>
>>> This commit documents some of the Vulkan filters. Some of this was
>>> copy-pasted from equivalent OpenCL filters.
>>>
>>
>> Pushed alongside the Vulkan patchset.
>>
>
> Were all 100 patches reviewed and approved?
>

As far as I can tell.
Niklas has taken a look at them and given his LGTM.elenril reviewed all patches up to
and including the common video decoding code. 
There was an issue with internal_ref, but internal_ref
turned out to be unneeded. I had a "okay then" after
"any other hidden API changes" which I interpreted as
at least any public-side changes and code up to common
video decoding being good. What was left - the codec files
themselves, are not doing anything other than copying struct
values and calling the common video decoding functions.
The patchset has been here in various forms since February,
in a stable form since April, in its current form, minus
a few cleanups and documentation since last week, and in its
final form, since late Friday, with many calls for reviews.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-05-28 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-28 15:54 Lynne
     [not found] ` <NWY3ISW--3-9@lynne.ee-NWY3MfM----9>
2023-05-28 22:55   ` Lynne
2023-05-28 22:57     ` James Almer
2023-05-28 23:38       ` Lynne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NWZiTGO--3-9@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git