Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )
Date: Thu, 25 May 2023 02:32:51 +0200 (CEST)
Message-ID: <NWFJdkx--3-9@lynne.ee> (raw)
In-Reply-To: <a810047b-9fc4-5bce-dce6-14487047ec8c@gmail.com>

May 24, 2023, 23:24 by leo.izen@gmail.com:

> On 5/24/23 16:35, Lynne wrote:
>
>> Patch attached.
>>
>
> +    av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str);
>
> The type of the first argument to av_log should be AVClass **, but this only appears to be AVClass *. See libavutil/log.c line 428.
>
> - Leo Izen
>

Right, thanks, changed to:

> static const AVClass tx_class = {
>     .class_name                = "tx",
>     .item_name                 = av_default_item_name,
>     .version                   = LIBAVUTIL_VERSION_INT,
> };
>
> static const struct {
>     const AVClass *tx_class;
> } tx_log = {
>     &tx_class,
> };
Will push this tomorrow.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".