From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec: add support for AAC SBR with 960 frame length
Date: Sun, 21 May 2023 05:31:08 +0200 (CEST)
Message-ID: <NVwM5L4--7-9@lynne.ee> (raw)
In-Reply-To: <NVuuZ7M--3-9@lynne.ee-NVuuc8h----9>
May 20, 2023, 22:47 by dev@lynne.ee:
> May 20, 2023, 22:17 by matthias@walliczek.de:
>
>> Supports the european DAB+ digital radio coding
>>
>> Fixes: https://trac.ffmpeg.org/ticket/1407 "HE-AAC (v2): 960/120 MDCT window is not implemented"
>>
>> Co-developed-by: Lynne <dev@lynne.ee>
>> Signed-off-by: Matthias Walliczek <matthias@walliczek.de>
>> ---
>> libavcodec/aacdec_template.c | 17 ++------------
>> libavcodec/aacps.c | 8 ++++---
>> libavcodec/aacps.h | 7 +++---
>> libavcodec/aacps_common.c | 3 ++-
>> libavcodec/aacsbr_template.c | 43 +++++++++++++++++++++---------------
>> libavcodec/sbr.h | 2 +-
>> 6 files changed, 38 insertions(+), 42 deletions(-)
>>
>
> Patch is malformed, still missing stuff, and I was just about to post
> an updated version of mine.
> Let's not step on each other's toes and let me take over?
>
Patch may take slightly longer.
I'm having to make new versions of the DSP functions too,
and the QMF synthesis code is also wrong. It really is not as simple
as changing a few constants, which is why I put it off.
Keep in mind even if it sounds somewhat right, it's still
unacceptable - there is only a single valid way of decoding a file.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-21 3:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 20:17 Matthias Walliczek
2023-05-20 20:46 ` Lynne
[not found] ` <NVuuZ7M--3-9@lynne.ee-NVuuc8h----9>
2023-05-21 3:31 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NVwM5L4--7-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git