From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 8x8 chroma blocks
Date: Thu, 18 May 2023 18:56:00 +0200 (CEST)
Message-ID: <NVjlmoe--3-9@lynne.ee> (raw)
In-Reply-To: <CAPUBFYFzkM+1ZBWMfk5B-64LCgY_A3d-mcNxJRyZ9-UjVyGP1g@mail.gmail.com>
May 18, 2023, 10:21 by arnie.chang@sifive.com:
> On Wed, May 17, 2023 at 10:54 PM Lynne <dev@lynne.ee> wrote:
>
>>
>> Finally, run:
>> make checkasm && ./tests/checkasm/checkasm --bench
>> and report on the timings for both the C and assembly versions.
>> If you've made a mistake somewhere, (forgot to restore stack, or a
>> callee-saved register,
>> or your function produces an incorrect result), checkasm will fail.
>>
>
> The checkasm does not cover motion compensation of chroma samples in the
> H.264 decoder,
> so my modification can not be tested.
>
I added one here http://ffmpeg.org/pipermail/ffmpeg-devel/2023-May/309812.html
follow the example and add a test next time.
I wouldn't accept risc-v asm without checkasm, the platform is too new (and doesn't
even have hardware yet), and probably prone to silicon issues.
We've found a few silicon bugs through checkasm over the years.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-18 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 7:13 Arnie Chang
2023-05-17 14:54 ` Lynne
2023-05-18 8:20 ` Arnie Chang
2023-05-18 12:53 ` Ronald S. Bultje
2023-05-18 16:56 ` Lynne [this message]
2023-05-19 17:15 ` Rémi Denis-Courmont
2023-05-19 18:52 ` Lynne
2023-05-20 9:59 ` Rémi Denis-Courmont
2023-05-20 10:03 ` Rémi Denis-Courmont
2023-05-19 17:12 ` Rémi Denis-Courmont
2023-05-22 14:15 ` Arnie Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NVjlmoe--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git