From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8A2B463B1 for ; Tue, 16 May 2023 14:41:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F37D168C06A; Tue, 16 May 2023 17:41:55 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3EC268C054 for ; Tue, 16 May 2023 17:41:49 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 84B541060235 for ; Tue, 16 May 2023 14:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1684248109; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=Vsgmt49LGrRYPlj5ihjMBpsbTafurEoetu3dLEWIRuY=; b=VfJA7+scn/TAwFIzS1z1621m0Br9QmZ28bGk9gPNUyJtI3c4yc7orlrtR0uxQKwm Jx8BXUrC4j89vPS71jbJf1VzjkyD1mykrAuQjz2mW9WALyUmqzwG1XRMYoc80IfxoAJ 27fYHbRchje1strZIdDESGp03PamR0hq74bg7KPmR2nThKeXxY0+2EoSkPAmZplMrRB AuEgv48wcepa127b8vOZvWDaRujewGPDHp52ET01XWNnIIAX1NY7f9MGDefc1OyyGJm kx7mwerTl9SMqIm7dIZQ2Xo+gGnzUjOE2+6UF8wmD8hbus+oBjalhNCtEkP48GSHH5M ayqD2u+iDQ== Date: Tue, 16 May 2023 16:41:49 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <168424400630.3843.7231613087858315843@lain.khirnov.net> References: <168382211746.3843.3110746372135356317@lain.khirnov.net> <168424400630.3843.7231613087858315843@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 16, 2023, 15:33 by anton@khirnov.net: > Quoting Lynne (2023-05-11 20:58:38) > >> May 11, 2023, 18:22 by anton@khirnov.net: >> >> > Quoting Lynne (2023-04-24 17:56:38) >> > >> >> From e20962a956444224b34d82f9a5936fae7e43bdf6 Mon Sep 17 00:00:00 2001 >> >> From: Lynne >> >> Date: Thu, 15 Dec 2022 17:43:27 +0100 >> >> Subject: [PATCH 47/97] vulkan: allow alloc pNext in ff_vk_create_buf >> >> >> >> --- >> >> libavutil/vulkan.c | 5 +++-- >> >> libavutil/vulkan.h | 3 ++- >> >> 2 files changed, 5 insertions(+), 3 deletions(-) >> >> >> >> diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c >> >> index b1553c6537..0bb5b1eebf 100644 >> >> --- a/libavutil/vulkan.c >> >> +++ b/libavutil/vulkan.c >> >> @@ -232,7 +232,8 @@ int ff_vk_alloc_mem(FFVulkanContext *s, VkMemoryRequirements *req, >> >> return 0; >> >> } >> >> >> >> -int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, void *pNext, >> >> +int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, >> >> + void *pNext, void *alloc_pNext, >> >> VkBufferUsageFlags usage, VkMemoryPropertyFlagBits flags) >> >> { >> >> int err; >> >> @@ -254,7 +255,7 @@ int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, void *pNe >> >> }; >> >> VkMemoryDedicatedAllocateInfo ded_alloc = { >> >> .sType = VK_STRUCTURE_TYPE_MEMORY_DEDICATED_ALLOCATE_INFO, >> >> - .pNext = NULL, >> >> + .pNext = alloc_pNext, >> >> }; >> >> VkMemoryDedicatedRequirements ded_req = { >> >> .sType = VK_STRUCTURE_TYPE_MEMORY_DEDICATED_REQUIREMENTS, >> >> diff --git a/libavutil/vulkan.h b/libavutil/vulkan.h >> >> index 85836a7807..d75be26977 100644 >> >> --- a/libavutil/vulkan.h >> >> +++ b/libavutil/vulkan.h >> >> @@ -413,7 +413,8 @@ int ff_vk_submit_exec_queue(FFVulkanContext *s, FFVkExecContext *e); >> >> /** >> >> * Create a VkBuffer with the specified parameters. >> >> */ >> >> -int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, void *pNext, >> >> +int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, >> >> + void *pNext, void *alloc_pNext, >> >> VkBufferUsageFlags usage, VkMemoryPropertyFlagBits flags); >> >> >> > >> > Shouldn't you be updating all the callers of this function here? >> > >> >> All callers of the function were in filters in libavfilter, and I wanted to keep all >> filter commits in libavfilter separate. >> > > Every commit must be buildable on its own. > fixed _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".