From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7C9BF462EE for ; Thu, 11 May 2023 19:12:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 69A5B68C0FE; Thu, 11 May 2023 22:12:01 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A62868C082 for ; Thu, 11 May 2023 22:11:55 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id BB8EE1060152 for ; Thu, 11 May 2023 19:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683832314; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=HW3jpIbGL8/TXR+cSCu6wPjH1DqoTg+Y9tn9CVIUiNw=; b=e8cD/lRZkRQAg6AvAYVDo4uQ9vvV2PPDu/a8U0A8poqch/AOjayj59AvdcLS7Vrw OaDhC+mtVtIYSZRvm/QeL9arMScdBSGiYKG5U3sJ3eiE34CpdzmLyqWuF510FAi6XiO /NAuUO4+SSFqy88tCtwdHMzyl6f5QXmnYHayGT0VsPigYzNsvMFssBlXcKBzzsHOqzg xN++oyQGc3fBFf0QVb2QHMjCxE7/+sZMb0Yo8/EaOgk1ACwurmpKatDnmkCdJ+zDv9b ND6vJrwsi+uBlmwHqKAB2+fXrqiqBL9Jjqr2bSdrldJwdlijjapGg8rJQRz6yxUVhk6 S+zV9yVhEQ== Date: Thu, 11 May 2023 21:11:54 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <168382602795.3843.9923140146921278092@lain.khirnov.net> References: <168382320471.3843.5279960795904250065@lain.khirnov.net> <168382602795.3843.9923140146921278092@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 11, 2023, 19:27 by anton@khirnov.net: > Quoting Lynne (2023-05-11 19:20:45) > >> May 11, 2023, 18:40 by anton@khirnov.net: >> >> > Quoting Lynne (2023-04-24 17:56:38) >> > >> >> @@ -3685,8 +3547,9 @@ static int vulkan_map_from(AVHWFramesContext *hwfc, AVFrame *dst, >> >> #endif >> >> #endif >> >> default: >> >> - return vulkan_map_frame_to_mem(hwfc, dst, src, flags); >> >> + break; >> >> >> > >> > This seems like it's also removing the ability to map to memory at all. >> > >> >> It is. Due to the driver deciding the layout of multiplane images >> (which are used by default), it's not spec-valid to map the memory >> used. Rather than keeping complicated code which receives no >> use at all, I decided to remove it. >> > > That should be stated more clearly in the commit message then, along > with the reason for dropping it. > Branch updated with all feedback. The top unsquashed commits remains as-is because I need to know whether "lavc/decode: allow to allocate hwaccel_priv_data early" is okay, as the commits are cleanups which would make reverting their squashing bug/time-consuming. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".