From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF525462B2 for ; Thu, 11 May 2023 16:47:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E09D568C0B0; Thu, 11 May 2023 19:47:52 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C952E68C05A for ; Thu, 11 May 2023 19:47:46 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 81B1B106034B for ; Thu, 11 May 2023 16:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683823666; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=xb3SMXlVrX/IOZ/mCcIdnTo70IHLsRbh4HwZOJBs5p8=; b=wOmNe9ZU5SmrtgKYuooy89PrkIv8TiwgPFTtyOGAon3s99y74V5XFvta54KNGyA0 abAmoKWZuD3fjJLqINfVxt88+QzshCbthbnbvaMfQTp6BAw5j1Ao/NIwViB4+BL6Htr uymirdT5gXbuIJIpS2NpJwiYFJduXNoRIvVSGMxqFFwXDFgIb1dHNofGdH5180eNcgm MJKA1cNXJgYA0R9NWuhF7+QL1cgUOq0R47I8qaMDPlrraVduEqmkbw7I3NgrcsAlZxL JSTzA+p7wnHRlbEhq1fnXW1/xJvljEFo4uqscrVDO9hmcdfq2gMlUyLHFfZdi9bBWFa fgLOlyhktg== Date: Thu, 11 May 2023 18:47:46 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <168382165941.3843.16293402618072713975@lain.khirnov.net> References: <168382165941.3843.16293402618072713975@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 11, 2023, 18:14 by anton@khirnov.net: > Quoting Lynne (2023-04-24 17:56:38) > >> From 956f043e9f233675856336e028cc8ee7e35c71f5 Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Wed, 23 Nov 2022 14:04:28 +0100 >> Subject: [PATCH 38/97] vulkan: lock queues before submitting operations >> >> --- >> libavutil/vulkan.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c >> index 6bf2c214b7..ad13b8f3cb 100644 >> --- a/libavutil/vulkan.c >> +++ b/libavutil/vulkan.c >> @@ -625,7 +625,14 @@ int ff_vk_submit_exec_queue(FFVulkanContext *s, FFVkExecContext *e) >> return AVERROR_EXTERNAL; >> } >> >> + s->hwctx->lock_queue((AVHWDeviceContext *)s->device_ref->data, >> + e->qf->queue_family, e->qf->cur_queue % e->qf->actual_queues); >> + >> ret = vk->QueueSubmit(q->queue, 1, &s_info, q->fence); >> + >> + s->hwctx->unlock_queue((AVHWDeviceContext *)s->device_ref->data, >> + e->qf->queue_family, e->qf->cur_queue % e->qf->actual_queues); >> + >> > > Should this patch be right after the one that adds these functions? > Yes. The patch before added support for them to the hwcontext. This patch uses them in vulkan.c, which, at the given position in the patchset is still an independent component only used for lavfi. I can squash them, but I'd prefer not to, though no strong feelings about it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".