From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B456C462AC for ; Thu, 11 May 2023 16:41:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 32A7368BCCE; Thu, 11 May 2023 19:41:01 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CFF468A48F for ; Thu, 11 May 2023 19:40:54 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 559EB10602E1 for ; Thu, 11 May 2023 16:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683823254; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=MRqQ+YGASoMcfjxJkkQuVBnMvHzTH4ig9erQvJUHqTA=; b=GJOXwooWXx3xaZHV+PDOBLmW71cErxv67eRZBkjA0YzV/S8l6cNURN9XJV+UJeI6 M2PYgvcA3gXYm25uOqs0WO9PN8cX/qrl6VDW4b9BO8CdUAu2n6Xdmdj21xxcFB8hVTX MGiEWBWK8dXmpJWP7P6brKvim2cQi+i2xsblCY/2AZRJproo0sUxCVX04bqszH0w8Ku 1IBnKcNRrKKMtKaFwWAo2NjjUH/PPidPtQ94yONfHNSi1W7xZHeh6JSzvMU8wOlZsSd faA61RpisclbI6NqQrk9hJgPKR/Jh2MI1SGA6VO4VrQbRFDCCGGPrE5n5cBew2RaPbk e6sb+jkEZw== Date: Thu, 11 May 2023 18:40:54 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <168382112350.3843.13088494193687499573@lain.khirnov.net> References: <168382112350.3843.13088494193687499573@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 11, 2023, 18:05 by anton@khirnov.net: > Quoting Lynne (2023-04-24 17:56:38) > >> From c50347a552f5c7c2e3fcf20ef9a1ad4f1a419918 Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Wed, 23 Nov 2022 20:32:49 +0100 >> Subject: [PATCH 27/97] hwcontext_vulkan: remove contiguous memory hack >> > > This needs a lot more context. > > What was the hack, why was it added, why is it being removed and what > will be affected by that. > The hack was added to enable exporting of vulkan images to DRM. On Intel hardware, specifically for DRM images, all planes must be allocated next to each other, due to hardware limitation, so the hack used a single large allocation and suballocated all planes from it. By natively supporting multiplane images, the driver is what decides the layout, so exporting just works. It's a hack because it conflicted heavily with image allocation, and with the whole ecosystem in general, before multiplane images were supported, which just made it redundant. This is also the commit which broke the hwcontext hardest and prompted the entire rewrite in the first place. >> diff --git a/libavutil/hwcontext_vulkan.h b/libavutil/hwcontext_vulkan.h >> index 406d8709c3..e89fa52927 100644 >> --- a/libavutil/hwcontext_vulkan.h >> +++ b/libavutil/hwcontext_vulkan.h >> @@ -160,9 +160,7 @@ typedef enum AVVkFrameFlags { >> * device and tiling during av_hwframe_ctx_init(). */ >> AV_VK_FRAME_FLAG_NONE = (1ULL << 0), >> >> - /* Image planes will be allocated in a single VkDeviceMemory, rather >> - * than as per-plane VkDeviceMemory allocations. Required for exporting >> - * to VAAPI on Intel devices. */ >> + /* DEPRECATED: does nothing. */ >> AV_VK_FRAME_FLAG_CONTIGUOUS_MEMORY = (1ULL << 1), >> > > If it's deprecated then it should actually be deprecated. > Done. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".