From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C59F45DC8 for ; Thu, 11 May 2023 09:32:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 25BD868BF33; Thu, 11 May 2023 12:32:37 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 749A968BF20 for ; Thu, 11 May 2023 12:32:30 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id AE78A10602DC for ; Thu, 11 May 2023 09:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1683797547; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=808cMBismJstjOs8zeDHwoIHF/7UFWhA/an4MwBiz34=; b=hxzcndTAfSdAoFzHlGNS7QRbrUsgpTB8+BzdN1fgwA34Z36haBAESHLG9TVZ9ET2 fzBcCJ+lkrZom2SIMk8NGx4uE/CvC6Zr7xS7/mHoFCjvpRNd19xhtX+Z+RIJT66zJxS FL1OvhkfWpArS+fZIiLfvBX8fEMIZdwxZGlqbHOQmfQJveSgCAlfzckhJMtMQ7/h40e R2oyJ1AeNGCrEy0N4u9nNyN5a2N85Meyjb8NWodN/GK3zxSu0xY+gmU7kVOWMKAlDgz zjbnP+BeAZin0eGcSYK4xt1b01ChXIZxquxkO6DtIbQZIYWdPgTp7mWQ9Dor6lKDQ9i iW4Of88lLA== Date: Thu, 11 May 2023 11:32:27 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20230511083902.7262-1-ffmpeg@haasn.xyz> References: <20230511082850.5289-1-ffmpeg@haasn.xyz> <20230511083902.7262-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_libplacebo: add vulkan device import fallback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 11, 2023, 10:39 by ffmpeg@haasn.xyz: > From: Niklas Haas > > Recent versions of libplacebo have required Vulkan versions incompatible > with lavu Vulkan hwcontexts. While this is expected to change > eventually, breaking vf_libplacebo every time there is such a transition > period is obviously undesired behavior, as the following sea of bug > reports shows. > > This commit adds a fallback path for pl_vulkan_import failures which > simply creates an internal device instead. Also useful when no interop > with lavu vulkan hwframes is needed or desired. > > Fixes: https://github.com/haasn/libplacebo/issues/170 > Fixes: https://github.com/mpv-player/mpv/issues/9589#issuecomment-1535432185 > Fixes: https://code.videolan.org/videolan/libplacebo/-/issues/270 > NAK. The whole point of the hwcontext infrastructure is to be explicit, and creating a new device behind the scenes is anything but that. Granted, this period of instability has gone too far, but I think we should work together to make sure there's interoperability, and after my patchset gets merged, there won't be much need to change anything in terms of enabled features for a while. Both libplacebo and the hwcontext have had a ton of changes recently, but before we started making changes, they were working fine for over a year. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".