Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_libplacebo: add vulkan device import fallback

[Lynne <dev@lynne.ee>]

May 11, 2023, 10:39 by ffmpeg@haasn.xyz:

> From: Niklas Haas <git@haasn.dev>
>
> Recent versions of libplacebo have required Vulkan versions incompatible
> with lavu Vulkan hwcontexts. While this is expected to change
> eventually, breaking vf_libplacebo every time there is such a transition
> period is obviously undesired behavior, as the following sea of bug
> reports shows.
>
> This commit adds a fallback path for pl_vulkan_import failures which
> simply creates an internal device instead. Also useful when no interop
> with lavu vulkan hwframes is needed or desired.
>
> Fixes: https://github.com/haasn/libplacebo/issues/170
> Fixes: https://github.com/mpv-player/mpv/issues/9589#issuecomment-1535432185
> Fixes: https://code.videolan.org/videolan/libplacebo/-/issues/270
>

NAK. The whole point of the hwcontext infrastructure is to be
explicit, and creating a new device behind the scenes is anything but that.

Granted, this period of instability has gone too far, but I think we should
work together to make sure there's interoperability, and after my
patchset gets merged, there won't be much need to change anything
in terms of enabled features for a while.

Both libplacebo and the hwcontext have had a ton of changes recently,
but before we started making changes, they were working fine for
over a year.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".