From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id B0C4A45F27
	for <ffmpegdev@gitmailbox.com>; Wed, 19 Apr 2023 14:50:07 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1345F68BF36;
	Wed, 19 Apr 2023 17:50:05 +0300 (EEST)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F30D68BE3D
 for <ffmpeg-devel@ffmpeg.org>; Wed, 19 Apr 2023 17:49:58 +0300 (EEST)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 2E3CF10600E8
 for <ffmpeg-devel@ffmpeg.org>; Wed, 19 Apr 2023 14:49:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1681915798; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=sDVulwHvoTZJPuRHOL5N0XrEYZyP6Y5qFYtiVb1SuSA=;
 b=0oKLfFsoTOKy1/7UWxL8E8IsNJzRdBdWRpaVghs8xwzoy47nafSD8W3ZXi1K6Xxm
 KvH8wCK+Woda26dZJbOt0sXp8k5Vb4XZgMQ/LEBOeIHAoPjDdoXwhj3Y6ioYR6fGvT5
 IjMfGemLdrcOO54DMN+F0/PHcmRuxj7zekUaMUfquYDu4/tElTMtf2Lg6R6mMitJ7Bz
 p1yKwigosCFec+GmO45qzHPjoIYx31pjx0bbOwlt8jA0lu9L3beyw5h9xFI5Nu9k7bu
 tvKgze99Ii71L0uPpjx7Mi3Vr1uqlCnLhOYlR668Cut3BzAOJDBLrHVjla5AxBJD/dn
 dfjntlkObA==
Date: Wed, 19 Apr 2023 16:49:58 +0200 (CEST)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <NTOza7N--B-9@lynne.ee>
In-Reply-To: <168172480343.3843.11801385323057244307@lain.khirnov.net>
References: <NQTold9--3-9@lynne.ee>
 <168172480343.3843.11801385323057244307@lain.khirnov.net>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common
 code changes
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/NTOza7N--B-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Apr 17, 2023, 11:46 by anton@khirnov.net:

> Quoting Lynne (2023-03-14 07:33:43)
>
>> From e37330cf6a1f768c733ca6d0b23b9e5847a5fe4f Mon Sep 17 00:00:00 2001
>> From: Lynne <dev@lynne.ee>
>> Date: Thu, 10 Mar 2022 18:03:05 +0100
>> Subject: [PATCH 25/92] avcodec: add AVHWAccel.free_frame_priv callback
>> diff --git a/libavcodec/decode.c b/libavcodec/decode.c
>> index d1ba7f167f..c4630ce275 100644
>> --- a/libavcodec/decode.c
>> +++ b/libavcodec/decode.c
>> @@ -1685,3 +1685,22 @@ int ff_copy_palette(void *dst, const AVPacket *src, void *logctx)
>>  }
>>  return 0;
>>  }
>> +
>> +AVBufferRef *ff_alloc_hwaccel_frame_priv_data(AVCodecContext *avctx,
>>
>
> Sane-endian naming please. ff_hwaccel_frame_priv_alloc().
>

Done


>> +                                              const AVHWAccel *hwaccel)
>> +{
>> +    AVBufferRef *ref;
>> +    uint8_t *data = av_mallocz(hwaccel->frame_priv_data_size);
>> +    if (!data)
>> +        return NULL;
>> +
>> +    ref = av_buffer_create(data, hwaccel->frame_priv_data_size,
>> +                           (void (*)(void *, uint8_t *))hwaccel->free_frame_priv,
>>
>
> I believe the cast is UB and you should convert the arguments in the
> function itself, or add a trivial wrapper here.
>

I converted the arguments of the function.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".