From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 80A6A45ACD
	for <ffmpegdev@gitmailbox.com>; Wed, 15 Mar 2023 19:41:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4241168BCA6;
	Wed, 15 Mar 2023 21:41:39 +0200 (EET)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 678C8680BC0
 for <ffmpeg-devel@ffmpeg.org>; Wed, 15 Mar 2023 21:41:32 +0200 (EET)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 165EA106016F
 for <ffmpeg-devel@ffmpeg.org>; Wed, 15 Mar 2023 19:41:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1678909292; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=Sys8SDoG79OJ5MopYhTWg4qM0VP9tX5y/7akkfc/Luw=;
 b=O4ieFMQco2kCUpv8kQOb8POREPg1vHJxztbcJMOLT+/IcByw/whOIzpVcg3NAUGA
 y49AcER6FH7H4u1VHE60bSdeMg0IlYXmhc/F4OXsAiE8HmWNsXHzyfqN3AztllEWsSg
 FbF/y50QHxGwZiRXMtEAcWi7PVQsL4OzyGY5YT2EmhExFwGusSxtT2u7zAPd9HwZlSk
 70k8KN5ER43ztXNW2HHfgZ60kYrWcdBXk65PNjgPy7r4Z3pqausaX2SEO0LUPydmMqa
 VzWl9m9njCd4eHHbnc9Y+mZETjuG8OB8Enk+GmfXYdNhOCd48qQquN3h8rCUpJ1Ibue
 mOEM2vFZWg==
Date: Wed, 15 Mar 2023 20:41:32 +0100 (CET)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <NQamfqS--3-9@lynne.ee>
In-Reply-To: <f1b8972a-47d9-b192-add8-7ce2548cdb9c@gmail.com>
References: <NQTold9--3-9@lynne.ee>
 <f1b8972a-47d9-b192-add8-7ce2548cdb9c@gmail.com>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common
 code changes
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/NQamfqS--3-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Mar 14, 2023, 12:51 by jamrial@gmail.com:

> On 3/14/2023 3:33 AM, Lynne wrote:
>
>>  +            for (int i = 0; i < 7; i++)
>> +                s->cur_frame.ref_order_hint[i] =
>> +                s->raw_frame_header->ref_order_hint[s->raw_frame_header->ref_frame_idx[i]];
>>
>
> Why do you need this in cur_frame? It's not a derived value, and the AV1RawFrameHeader struct is accessible in all AVHWaccel callbacks.
>
> And i think you should be looking at s->ref[s->raw_frame_header->ref_frame_idx[i]].raw_frame_header->order_hint instead, too, which is the decoder state vs the raw values in the current frame header (Although they should match in theory).
>
>> +
>>  if (avctx->hwaccel && s->cur_frame.f->buf[0]) {
>>  ret = avctx->hwaccel->start_frame(avctx, unit->data,
>>

Fixed, removed the commit altogether and just used the value directly.
Thanks for the review
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".