From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0FE0445725 for ; Sun, 19 Feb 2023 18:47:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BF31668BF56; Sun, 19 Feb 2023 20:47:41 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C008168BD86 for ; Sun, 19 Feb 2023 20:47:35 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 783021060155 for ; Sun, 19 Feb 2023 18:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1676832455; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=8N0CFuMcukmAJxcHrtMnsjjWCf/GBtwswkCdqZ1XqSw=; b=RmafqdkeyDjnDGJQ3V6xaGcOMsilMMCReq/zU84gpsdAPqCDbiffnjYxCU0WKKdk t1NmEDqTazwKUzLPr0KHrr7fka232gWWG76tPunEcx9nqaR5jVpQcYJA9K5oxtGSyZl p8XCET5yZ7puCPBBMHiVCBttNDnCBK5lyIdjc3GQh7V7tqqq5MS23uGP3ZHwwfTFUrT uA5+/ajlRKHeHNK7pCGDMZRgMfX6zPH5+WiuourlK/+XWtgA1cXvIMbOw4Qcv2aIMNC LcTg9x9R69qFp+Xq89rNVAuAZG4wchXo0DgcOtJD4QRrbZCTEHJ4rPqlWkOBhxSCF4+ RqWSCSy0/A== Date: Sun, 19 Feb 2023 19:47:35 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> <077fbbad-3629-c057-1d5d-d59fece7eed9@gmail.com> <14d18141-4e19-7c28-427f-a7d12cc2486b@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 18, 2023, 15:53 by dev@lynne.ee: > Feb 18, 2023, 14:58 by jamrial@gmail.com: > >> On 2/18/2023 10:45 AM, Lynne wrote: >> >>> Feb 18, 2023, 14:32 by jamrial@gmail.com: >>> >>>> On 2/18/2023 9:49 AM, Lynne wrote: >>>> >>>>> Feb 17, 2023, 19:45 by dev@lynne.ee: >>>>> >>>>>> Feb 17, 2023, 18:08 by jamrial@gmail.com: >>>>>> >>>>>>> On 2/17/2023 1:54 PM, Lynne wrote: >>>>>>> >>>>>>>> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. >>>>>>>> >>>>>>>> All filters and all codecs (except wmavoice) have been ported for the >>>>>>>> lavu/tx API. >>>>>>>> >>>>>>>> The noise should be minimal. >>>>>>>> >>>>>>> >>>>>>> It isn't. I'm getting more than two thousand lines of warnings after applying this patch from >>>>>>> >>>>>>> libavfilter/vf_spp.c >>>>>>> libavfilter/x86/vf_spp.c >>>>>>> libavcodec/asvenc.c >>>>>>> libavcodec/avdct.c >>>>>>> libavcodec/avfft.c >>>>>>> libavcodec/dct.c >>>>>>> libavcodec/fdctdsp.c >>>>>>> libavcodec/fft_float.c >>>>>>> libavcodec/fft_init_table.c >>>>>>> libavcodec/idctdsp.c >>>>>>> libavcodec/jfdctfst.c >>>>>>> libavcodec/jfdctint.c >>>>>>> libavcodec/jrevdct.c >>>>>>> libavcodec/mpegaudiodsp.c >>>>>>> libavcodec/mpegvideo_enc.c >>>>>>> libavcodec/rdft.c >>>>>>> libavcodec/wmavoice.c >>>>>>> libavcodec/x86/dct_init.c >>>>>>> libavcodec/x86/fft_init.c >>>>>>> libavcodec/x86/mpegvideoenc.c >>>>>>> >>>>>>> It's not just wmavoice, there's also mpeg and jpeg stuff, and one filter. For the actual fft/dct/rdft/mdct source files, you should use the deprecation warning pragmas to silence them, but the other modules need to be ported. >>>>>>> This patch is also missing the schedule FF_API deprecation wrapper. >>>>>>> >>>>>> >>>>>> Is the noise acceptable if I just deprecate the functions? >>>>>> It wasn't before, but it should be much less now. >>>>>> >>>>> >>>>> Version 2 attached. >>>>> Deprecates only the init functions (which must always be used, therefore >>>>> the entire API is deprecated). >>>>> >>>> >>>> You should deprecate all the functions, not just the init ones, even if the rest depend on them. And add a "@deprecated use AVTXContext from libavutil/tx.h" line or similar in the doxy for at least the init or alloc functions to point library users to the replacement API. >>>> >>> >>> Fair enough, deprecated all functions, added disable/enable warnings to tests >>> and vf_spp, and added the doxy note. >>> Attached v3. >>> >> >> vf_spp should be ported to tx, not the avdct functions silenced. You're just scheduling a compilation failure as is. >> > > There's enough time to port it, a whole year in fact. > > >> What is the plan for the internal version of all this lavc code? Is it going to be removed and wmavoice/mpegaudiodsp/etc ported to tx? Because it depends on structs defined in the public headers you're scheduling to be removed. >> > > Yes, all internals will be removed when I port wmavoice. > I have a DST-I and a DCT-I ready, but they're naive. > They're still fast enough for wmavoice, but I went down > looking for a faster way... > Ping. This should go in before the bump. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".