From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 842D94569D for ; Fri, 17 Feb 2023 18:45:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 307B468BE25; Fri, 17 Feb 2023 20:45:18 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E614068BC49 for ; Fri, 17 Feb 2023 20:45:11 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 8598A1060170 for ; Fri, 17 Feb 2023 18:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1676659511; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=FHMgKMabKHqOIh4MsReddKLEttKhM2EbgZ7tD0/SoUc=; b=bn/m4x5HMWhvqukUhieDDTQqastMAt4xhsRabS9PK2xt58NIlzD3qthJNwFIKvqk /ba41HuXxDsgMjIkMk67mLm2e1J3GGHOo2esCdpy4Pkzny2yzl4LOcccqOOT1bHEecs 4uPGEoKNya0t7sYhmksuyMNioWVM9gcyfZ0A+HdzTIpAvLHLJFb1V9nDOt1/xwQRh+R YkC/HhOxdhqrtg24GIMQGOi/d+LYRNw/abwylTlQrXDtsRY38QNYGV1xTHxQL3iKoGR /6P2Y1tk4rMSOCstltLDAwmTo1DpHzBqt6o9eH6EsT5L2McgG/hkTOxHt+dF7HPAPbi d9UDqlc6FA== Date: Fri, 17 Feb 2023 19:45:11 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> References: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 17, 2023, 18:08 by jamrial@gmail.com: > On 2/17/2023 1:54 PM, Lynne wrote: > >> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. >> >> All filters and all codecs (except wmavoice) have been ported for the >> lavu/tx API. >> >> The noise should be minimal. >> > > It isn't. I'm getting more than two thousand lines of warnings after applying this patch from > > libavfilter/vf_spp.c > libavfilter/x86/vf_spp.c > libavcodec/asvenc.c > libavcodec/avdct.c > libavcodec/avfft.c > libavcodec/dct.c > libavcodec/fdctdsp.c > libavcodec/fft_float.c > libavcodec/fft_init_table.c > libavcodec/idctdsp.c > libavcodec/jfdctfst.c > libavcodec/jfdctint.c > libavcodec/jrevdct.c > libavcodec/mpegaudiodsp.c > libavcodec/mpegvideo_enc.c > libavcodec/rdft.c > libavcodec/wmavoice.c > libavcodec/x86/dct_init.c > libavcodec/x86/fft_init.c > libavcodec/x86/mpegvideoenc.c > > It's not just wmavoice, there's also mpeg and jpeg stuff, and one filter. For the actual fft/dct/rdft/mdct source files, you should use the deprecation warning pragmas to silence them, but the other modules need to be ported. > This patch is also missing the schedule FF_API deprecation wrapper. > Is the noise acceptable if I just deprecate the functions? It wasn't before, but it should be much less now. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".