From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 64EBD452EA for ; Fri, 17 Feb 2023 11:50:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CBE568BE25; Fri, 17 Feb 2023 13:50:05 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 06C71680A8D for ; Fri, 17 Feb 2023 13:49:58 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 7BB1C10602DF for ; Fri, 17 Feb 2023 11:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1676634598; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=wlqaXiGS8Iv6RPwAUb8DlOPkDXKsqGbzoigRr3Nj1CM=; b=ax5c9FV1BVEtDX4irZ2nVA90x//XQG0gb0/fAuJL/PiUoHHFRZzBqZr6d8w6Y5fB TdFud49zUzXdo7Ub7Htyw5cHizBqpG2XhhKC4CfHZTuXNcz3IIPQ9g2Rfqkp+VPPoXA wXB2cJzZwyOCAcewGPRhpDwuwoud0pu0ncTMCKgsXMa2lJpcyig2bO21OnXCn+N5pqD oAP+tFJQYf6jiojjCr1QzKyxIBVJCcP3IphlFcnYJTckGLf4nEI4QNswNpCw9RptXUC 1JcdrWgF3+3tYZtpZZFSjVyRy1PuoxhL5BhgJrwh2TRs7ZFdgDujPmOZ6sbIGLhqDhe N2niWWnnXQ== Date: Fri, 17 Feb 2023 12:49:58 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <167663206793.1179.18261691439793810470@lain.khirnov.net> References: <9135ef14-f767-095d-5ea6-40c9df9e0695@noa-archive.com> <167663206793.1179.18261691439793810470@lain.khirnov.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 17, 2023, 12:08 by anton@khirnov.net: > Quoting Prakash (2023-02-17 01:16:04) > >> Moved the timestamp to the front (before loglevel but after the prefix if >> present, so the timestamp has the same color as log line based on log >> level). Updated the patch and attached again. >> >> >> From 04857a7bf0d4cf24a479e795a55a61ab2e2f618e Mon Sep 17 00:00:00 2001 >> From: Prakash Duggaraju >> Date: Thu, 16 Feb 2023 16:06:29 -0800 >> Subject: [PATCH] libavutil/log: Support for logging timestamps in the log. >> Add >> 'time' flag to the -loglevel option to turn on timestamp logging. Useful >> for >> troubleshooting where time is spent from the log files. >> >> Signed-off-by: Prakash Duggaraju >> --- >> doc/fftools-common-opts.texi | 4 ++++ >> fftools/opt_common.c | 6 ++++++ >> libavutil/log.c | 41 +++++++++++++++++++++++++----------- >> libavutil/log.h | 8 +++++++ >> 4 files changed, 47 insertions(+), 12 deletions(-) >> > > I do not like this patch. > > The default logging callback should be simple and straightforward, not a > kitchen sink of all possible functionality. > > Callers who need this can and should implement this themselves. > Same, having the class pointer makes it already quite busy. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".