From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C8434452DA for ; Fri, 17 Feb 2023 10:45:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 72E2A68BE68; Fri, 17 Feb 2023 12:45:51 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE08B68BD86 for ; Fri, 17 Feb 2023 12:45:44 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 5D3A710602F3 for ; Fri, 17 Feb 2023 10:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1676630744; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=QgixMRQRel2TwoXmi7lySb/nyIjpt1edu7i9MitcUlU=; b=i/TPdpVGxXeRxNCa2xZ1m6QPIxMdthKqlDOJCt1t3/CWCMO+urnaEKPd27JbRWVM kjEZXW6gnCkFSk9XUlZPkHDTwaG4YxUyd3Lksifh/g4nXUqrbcxAPFEV87bRMtyteOs hIibWfQRQV6M2H3MWismfnBYpFl+opGLlBCMxbvWnlWc1kIGyAuggAAxEpFfyiCMlik 8vmrKRQQCLf9cVfHeV7QEds5LRIXiKVj+QX01lrtugKZy7zn425ERcCSQywf2xp6JFR 4bgmPLtLM+0DQ9t0Trc2ah8c5RHBgl/eLAlNFT7jEFxDvbFzG5ttemRgefr6l16GW3L Gg+25xWD6A== Date: Fri, 17 Feb 2023 11:45:44 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: <8d23d0d4-51bd-4ae4-ba00-3ec328978647@betaapp.fastmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 17, 2023, 10:45 by h.leppkes@gmail.com: > On Fri, Feb 17, 2023 at 10:09 AM Jean-Baptiste Kempf wrote: > >> >> Hello, >> >> On Fri, 17 Feb 2023, at 04:43, Lynne wrote: >> > This small patchset mostly rewrites Vulkan to enable using multiplane images, >> >> This is not small. We're talking about thousands of lines of code; >> >> And this changes numerous h264 and hevc headers, and adds callback to the make AVHWAccel. >> >> And that is besides the full rewrite of some Vulkan files... >> >> This will take a long time to review. >> > > I would agree, this set is too large to try to skirt it in just under > the deadline of a new release, with the potential of needing to fix > stuff later. > Just have it land on master after the branch, and there is no time > pressure to review it, or make numerous fixes on the release branch. > The code's been tested by a lot of folks already, and importantly, passes the validation layers (with some warnings due to spec issues that the workgroup agreed to fix). The output is also conformant on all implementations. All the code needs is some looking over to make sure I haven't done something silly. Valgrind output is clean too. It is a lot of code in terms of diff, but rather than reviewing each patch individually, you should just try looking at the final files directly, that way, you only have a few thousand lines to look at, rather than a few thousand times twenty. I've abstracted all the low-level Vulkan stuff from the decoding patchset, so the output is high-level enough that anyone who's written hwaccels can understand it. > PS: > Can you please send it as a proper patchset? Reviewing 72 patches off > of one mail is not really fitting the workflow at all. > I'll do that. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".