From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/av1_vaapi: add direct film grain mode
Date: Mon, 21 Nov 2022 23:03:19 +0100 (CET)
Message-ID: <NHRCt6x--7-9@lynne.ee> (raw)
In-Reply-To: <20221121195048.240417-1-ruijing.dong@amd.com>
Nov 21, 2022, 20:50 by ruijing.dong@amd.com:
> Add flag AV_VAAPI_DRIVER_QUIRK_DIRCT_FILM_GRAIN_ATTRIBUTES to
> specify a direct film grain mode for AMD av1 decoder.
>
> issue:
> By using AMD av1 decoder via VAAPI, when used with film
> grain content, the output displays black screen with
> incorrect frame order.
>
> The issue being discussed in here:
> https://gitlab.freedesktop.org/mesa/mesa/-/issues/6903#note_1613807
>
> Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
> Signed-off-by: nyanmisaka <nst799610810@gmail.com>
> ---
>
> update: using driver_quirks to identify AMD driver instead of
> extra AV_HWACCEL_FLAG.
>
> libavcodec/avcodec.h | 1 -
> libavcodec/vaapi_av1.c | 6 ++++--
> libavutil/hwcontext_vaapi.c | 5 +++++
> libavutil/hwcontext_vaapi.h | 6 ++++++
> 4 files changed, 15 insertions(+), 3 deletions(-)
>
I think this looks fine. Just needs a micro bump and APIchanges,
but whoever commits it can apply that.
jkqxz should take a look at it too.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-11-21 22:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 15:34 [FFmpeg-devel] [PATCH] " Ruijing Dong
2022-11-20 2:59 ` [FFmpeg-devel] [PATCH v2] " Ruijing Dong
2022-11-20 16:44 ` Mark Thompson
2022-11-22 19:18 ` Dong, Ruijing
2022-11-22 20:26 ` Mark Thompson
2022-11-22 20:59 ` Mark Thompson
2022-11-22 23:34 ` Mark Thompson
2022-11-23 2:43 ` Dong, Ruijing
2022-11-24 15:27 ` Dong, Ruijing
2022-11-24 21:09 ` Mark Thompson
2022-11-24 21:22 ` Dong, Ruijing
2022-11-21 19:50 ` [FFmpeg-devel] [PATCH v3] " Ruijing Dong
2022-11-21 22:03 ` Lynne [this message]
2022-11-22 4:37 ` Xiang, Haihao
2022-11-22 16:28 ` [FFmpeg-devel] [PATCH v4] " Ruijing Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NHRCt6x--7-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git