From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DCF4E4449D for ; Thu, 13 Oct 2022 12:37:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7710B68BD3D; Thu, 13 Oct 2022 15:37:26 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A351768BB95 for ; Thu, 13 Oct 2022 15:37:20 +0300 (EEST) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id BBE8F106025B for ; Thu, 13 Oct 2022 12:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1665664639; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=d2Dk66BGK1p1TBNz32k1Knmq+b59L/EGZID82pxuMLw=; b=aKggAueJTisF/Cg7EMwjr4hPfCzp+gBOijP84Ac3n+ChzocIHR0zHWksOMZPy0K5 Ex1Ch0etVdbuxlbaM2e+sL84BW500tWsX97JxhmLmQnMjIi92+OwL4Voda6y0G6rdXR 4VA1Gf8gjIY82RUjrzBIKAE3pR29e1hvCKIeJHqNU2tXnilkpO5vBS/4PB7uOaUPzfD S4I9f8lPW+TvQb7R321mJ9H4bALrS11YaESxXiQB4iSZw9m3UkvdGOnp8jJVL1UrOuT q8i3xTcZhddO7hgKslldUQpuGuviCMKTnIKgD2J0Ws5xG+MWPRkz/HqHYqx9aAFRYGY jPhhQA1KIw== Date: Thu, 13 Oct 2022 14:37:19 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Oct 12, 2022, 13:09 by toqsxw@outlook.com: > [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding > > Patch attached. > The Sync locking functions and the queue locking functions should be a function pointer in the device/frame context. Vulkan has the same issue, and that's how I did it there. This allows for API users to plug their own locking primitives in, which they need to in case they initialize their own contexts. You should also document which fields API users have to set themselves if they plan to use their own context. Also, struct names in the public context lack an AV prefix. D3D12VA_MAX_SURFACES is a terrible hack. Vendors should fix their own drivers rather than users running out of memory. Also, you have code style issues, don't wrap one-line if statements or loops in brackets. ff_d3d12dec_get_suitable_max_bitstream_size is an awful function. It does float math for sizes and has a magic mult factor of 1.5. You have to calculate this properly. On a first look, this is what stands out. Really must be split apart in patches. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".