From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding
Date: Thu, 13 Oct 2022 14:37:19 +0200 (CEST)
Message-ID: <NEGLL5h--B-2@lynne.ee> (raw)
In-Reply-To: <OSZP286MB2173C3D06713BCECA18FBA5BCA229@OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM>
Oct 12, 2022, 13:09 by toqsxw@outlook.com:
> [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding
>
> Patch attached.
>
The Sync locking functions and the queue locking functions should
be a function pointer in the device/frame context. Vulkan has
the same issue, and that's how I did it there. This allows for
API users to plug their own locking primitives in, which they need
to in case they initialize their own contexts.
You should also document which fields API users have to set
themselves if they plan to use their own context.
Also, struct names in the public context lack an AV prefix.
D3D12VA_MAX_SURFACES is a terrible hack. Vendors should
fix their own drivers rather than users running out of memory.
Also, you have code style issues, don't wrap one-line if statements
or loops in brackets.
ff_d3d12dec_get_suitable_max_bitstream_size is an awful function.
It does float math for sizes and has a magic mult factor of 1.5.
You have to calculate this properly.
On a first look, this is what stands out. Really must be split apart
in patches.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-13 12:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OSZP286MB2173BE661B9E9F1FDBAB4D1DCA229@OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM>
2022-10-12 11:09 ` Wu Jianhua
2022-10-12 15:12 ` Jean-Baptiste Kempf
2022-10-12 15:25 ` James Almer
2022-10-12 16:25 ` Wu Jianhua
2022-10-13 12:37 ` Lynne [this message]
2022-10-13 15:48 ` Wu Jianhua
2022-10-13 16:04 ` James Almer
2022-10-13 16:08 ` Wu Jianhua
2022-10-13 22:28 ` Lynne
2022-10-14 12:32 ` Wu Jianhua
2022-10-15 5:16 ` Lynne
2022-11-11 16:41 ` Wu Jianhua
2022-11-11 16:50 ` Wu Jianhua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NEGLL5h--B-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git