From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] riscv: remove unnecessary #include's
Date: Wed, 5 Oct 2022 07:02:00 +0200 (CEST)
Message-ID: <NDaWPRS--3-2@lynne.ee> (raw)
In-Reply-To: <20221004174913.49181-1-remi@remlab.net>
Oct 4, 2022, 19:49 by remi@remlab.net:
> Pointed out by Andreas Rheinhardt.
> ---
> libavcodec/riscv/fmtconvert_rvv.S | 1 -
> libavcodec/riscv/idctdsp_rvv.S | 1 -
> libavcodec/riscv/pixblockdsp_rvi.S | 1 -
> libavcodec/riscv/pixblockdsp_rvv.S | 1 -
> libavcodec/riscv/vorbisdsp_rvv.S | 1 -
> libavutil/riscv/asm.S | 2 --
> libavutil/riscv/fixed_dsp_rvv.S | 1 -
> libavutil/riscv/float_dsp_rvv.S | 1 -
> 8 files changed, 9 deletions(-)
>
> diff --git a/libavcodec/riscv/fmtconvert_rvv.S b/libavcodec/riscv/fmtconvert_rvv.S
> index 49893ec8d7..51365753d9 100644
> --- a/libavcodec/riscv/fmtconvert_rvv.S
> +++ b/libavcodec/riscv/fmtconvert_rvv.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "libavutil/riscv/asm.S"
>
> func ff_int32_to_float_fmul_scalar_rvv, zve32f
> diff --git a/libavcodec/riscv/idctdsp_rvv.S b/libavcodec/riscv/idctdsp_rvv.S
> index f5e1165eee..06e64e6529 100644
> --- a/libavcodec/riscv/idctdsp_rvv.S
> +++ b/libavcodec/riscv/idctdsp_rvv.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "libavutil/riscv/asm.S"
>
> func ff_put_pixels_clamped_rvv, zve32x
> diff --git a/libavcodec/riscv/pixblockdsp_rvi.S b/libavcodec/riscv/pixblockdsp_rvi.S
> index e84170244b..efdd422228 100644
> --- a/libavcodec/riscv/pixblockdsp_rvi.S
> +++ b/libavcodec/riscv/pixblockdsp_rvi.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "libavutil/riscv/asm.S"
>
> func ff_get_pixels_8_rvi
> diff --git a/libavcodec/riscv/pixblockdsp_rvv.S b/libavcodec/riscv/pixblockdsp_rvv.S
> index c125408523..1a364e6dab 100644
> --- a/libavcodec/riscv/pixblockdsp_rvv.S
> +++ b/libavcodec/riscv/pixblockdsp_rvv.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "libavutil/riscv/asm.S"
>
> func ff_get_pixels_8_rvv, zve32x
> diff --git a/libavcodec/riscv/vorbisdsp_rvv.S b/libavcodec/riscv/vorbisdsp_rvv.S
> index bbe9c7dc6d..f45e7dc2f1 100644
> --- a/libavcodec/riscv/vorbisdsp_rvv.S
> +++ b/libavcodec/riscv/vorbisdsp_rvv.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "libavutil/riscv/asm.S"
>
> func ff_vorbis_inverse_coupling_rvv, zve32f
> diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S
> index de5e1ad0a6..ffa0bd9068 100644
> --- a/libavutil/riscv/asm.S
> +++ b/libavutil/riscv/asm.S
> @@ -19,8 +19,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> -
> #if defined (__riscv_float_abi_soft)
> #define NOHWF
> #define NOHWD
> diff --git a/libavutil/riscv/fixed_dsp_rvv.S b/libavutil/riscv/fixed_dsp_rvv.S
> index 0e78734b4c..a91316e1da 100644
> --- a/libavutil/riscv/fixed_dsp_rvv.S
> +++ b/libavutil/riscv/fixed_dsp_rvv.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "asm.S"
>
> // (a0) = (a0) + (a1), (a1) = (a0) - (a1) [0..a2-1]
> diff --git a/libavutil/riscv/float_dsp_rvv.S b/libavutil/riscv/float_dsp_rvv.S
> index ab2e0c42d7..2bf8c6ee96 100644
> --- a/libavutil/riscv/float_dsp_rvv.S
> +++ b/libavutil/riscv/float_dsp_rvv.S
> @@ -18,7 +18,6 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#include "config.h"
> #include "asm.S"
>
> // (a0) = (a1) * (a2) [0..a3-1]
>
Pushed alongside the alacdsp patch.
Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-10-05 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 17:49 Rémi Denis-Courmont
2022-10-05 5:02 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NDaWPRS--3-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git