From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dirac_dwt(_template): Don't use ff_-prefix for static func
Date: Wed, 28 Sep 2022 04:39:06 +0200 (CEST)
Message-ID: <ND0xZqV--3-2@lynne.ee> (raw)
In-Reply-To: <GV1P250MB0737AFFC2FA6E4DCDDC39E9B8F549@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Sep 28, 2022, 03:05 by andreas.rheinhardt@outlook.com:
> Andreas Rheinhardt:
>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> libavcodec/dirac_dwt.c | 6 +++---
>> libavcodec/dirac_dwt_template.c | 2 +-
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavcodec/dirac_dwt.c b/libavcodec/dirac_dwt.c
>> index af29932c6d..4039899cf0 100644
>> --- a/libavcodec/dirac_dwt.c
>> +++ b/libavcodec/dirac_dwt.c
>> @@ -45,11 +45,11 @@ int ff_spatial_idwt_init(DWTContext *d, DWTPlane *p, enum dwt_type type,
>> d->decomposition_count = decomposition_count;
>>
>> if (bit_depth == 8)
>> - ret = ff_spatial_idwt_init_8bit(d, type);
>> + ret = spatial_idwt_init_8bit(d, type);
>> else if (bit_depth == 10)
>> - ret = ff_spatial_idwt_init_10bit(d, type);
>> + ret = spatial_idwt_init_10bit(d, type);
>> else if (bit_depth == 12)
>> - ret = ff_spatial_idwt_init_12bit(d, type);
>> + ret = spatial_idwt_init_12bit(d, type);
>> else
>> av_log(NULL, AV_LOG_WARNING, "Unsupported bit depth = %i\n", bit_depth);
>>
>> diff --git a/libavcodec/dirac_dwt_template.c b/libavcodec/dirac_dwt_template.c
>> index 5d55d932a1..f1d7f8b22f 100644
>> --- a/libavcodec/dirac_dwt_template.c
>> +++ b/libavcodec/dirac_dwt_template.c
>> @@ -516,7 +516,7 @@ static void RENAME(spatial_compose_dd137i_init)(DWTCompose *cs, uint8_t *buffer,
>> cs->y = -5;
>> }
>>
>> -static int RENAME(ff_spatial_idwt_init)(DWTContext *d, enum dwt_type type)
>> +static int RENAME(spatial_idwt_init)(DWTContext *d, enum dwt_type type)
>> {
>> int level;
>>
>
> Will apply tonight unless there are objections.
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-09-28 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 23:00 Andreas Rheinhardt
2022-09-25 23:01 ` [FFmpeg-devel] [PATCH 2/2] avcodec/dirac_dwt: Avoid conversions between function pointers and void* Andreas Rheinhardt
2022-09-28 1:05 ` [FFmpeg-devel] [PATCH 1/2] avcodec/dirac_dwt(_template): Don't use ff_-prefix for static func Andreas Rheinhardt
2022-09-28 2:39 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ND0xZqV--3-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git