From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] add a configure flag to enabled tree-vecorization with gcc
Date: Mon, 8 Aug 2022 21:31:05 +0200 (CEST)
Message-ID: <N8yw6Y5--3-2@lynne.ee> (raw)
In-Reply-To: <fd2ce78bb11d457481cdcca122c1ad64@amazon.com>
Aug 8, 2022, 17:25 by jswinney@amazon.com:
> Recent version of gcc improve the automatic vectorization. This flag
> allows adventurous users to enable vectorization. Known problems with
> this are primarily related to inline assembly for x86 and so to address
> those, add a pragma to explicitly disable automatic vectorization for
> those files.
>
> Signed-off-by: Jonathan Swinney <jswinney@amazon.com>
>
> --
>
> Thank you considering this patch. I believe this addresses the primary
> concerns that were raised by my previous submission. There may be more
> files which require the pragma add `-fno-tree-vectorize`, and I welcome
> suggestions. This should strike a compromise, allowing some users to
> enable vectorization while not breaking mainstream builds. This should
> give time to work out additional problems if they arise before enabling
> vectorization more broadly.
>
I dislike this, pretty soon we'll end up with compiler version checks
whenever vectorization breaks.
Either gcc should fix miscompilation, or patches should be sent
to write assembly (which they should be anyway).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-08 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 15:25 Swinney, Jonathan
2022-08-08 19:31 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=N8yw6Y5--3-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git