From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 861A540B35 for ; Fri, 6 May 2022 18:30:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 620B868B345; Fri, 6 May 2022 21:29:59 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 856FE688166 for ; Fri, 6 May 2022 21:29:52 +0300 (EEST) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 0648310602D1 for ; Fri, 6 May 2022 18:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651861791; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=HlpfmOGJX1Gbo2lG4/v5bgPRRopBdSfj5IsFNa0NE7c=; b=TWy+Qab/ZFOqyNuzWoYCHkG7ByEkN8HW79G50BAhkFeGfFtzD/OFv72MEK+Yun+Y 4eFE832rFTaCe20eIViNCkrHZbybHQS9vUvuHktu4W8DXsB/rjbZQc44vPOehX9iBw+ mCfYXAFuH9q5pU8+KDBl86IBqr1wJUru437x0lPMcMFBlFIA2uEYPKQ6K6Hvxik1pqu MfiAf/OjSzoRfLBEmHVHWcnRVKf6uXkTfcvDaOjMIDgindCBGNP0vuxheM3s7mvDLCh Hxja3JdhZzcULItgFGuF5rNfyFsMfVaMISAjke16LGPgHEFseki1kuVq6dh/C47rigq rHpm11UK9A== Date: Fri, 6 May 2022 20:29:51 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20220505004701.75011573@davids-macbook-pro-4.local> References: <20220505004701.75011573@davids-macbook-pro-4.local> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: 5 May 2022, 01:47 by David@megapico.co.uk: >> Andreas Rheinhardt wrote: >> >> David Fletcher: >> > Following today's posts about help with submitting patches I realised I >> > sent the libmad patch yesterday in the wrong format. Apologies, I was >> > not familiar with the git format patches. >> > >> > Hopefully the attached version is now in the correct format against the >> > current master branch. >> > >> > The bug report about why this exists is at the following link, including >> > a link to sample distorted audio from decoding an mp3 stream on ARMv4 >> > hardware: https://trac.ffmpeg.org/ticket/9764 >> > >> > Best regards, David. >> > >> I disagree with this patch. The native decoder should be fixed instead, or if it's not able to be fixed, users should use specialized libraries. We're not adding a yet another decoding library to fix an issue on very old ARM chips. I suspect the problem is with the MDCT. We already have a better and more precise fixed-point MDCT in libavutil/tx. The plan was to replace the MDCT in mp3 once lavu/tx has more assembly, but if it helps, should be fine to replace it now. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".