Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support
Date: Fri, 6 May 2022 20:29:51 +0200 (CEST)
Message-ID: <N1Pce7r--3-2@lynne.ee> (raw)
In-Reply-To: <20220505004701.75011573@davids-macbook-pro-4.local>

5 May 2022, 01:47 by David@megapico.co.uk:

>> Andreas Rheinhardt wrote:
>>
>> David Fletcher:
>> > Following today's posts about help with submitting patches I realised I
>> > sent the libmad patch yesterday in the wrong format. Apologies, I was
>> > not familiar with the git format patches.
>> > 
>> > Hopefully the attached version is now in the correct format against the
>> > current master branch.
>> > 
>> > The bug report about why this exists is at the following link, including
>> > a link to sample distorted audio from decoding an mp3 stream on ARMv4
>> > hardware: https://trac.ffmpeg.org/ticket/9764
>> > 
>> > Best regards, David.
>> > 
>>

I disagree with this patch. The native decoder should be fixed instead,
or if it's not able to be fixed, users should use specialized libraries.
We're not adding a yet another decoding library to fix an issue on
very old ARM chips.

I suspect the problem is with the MDCT. We already have a better and
more precise fixed-point MDCT in libavutil/tx. The plan was to replace
the MDCT in mp3 once lavu/tx has more assembly, but if it helps,
should be fine to replace it now.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-05-06 18:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 23:47 David Fletcher
2022-05-06 18:29 ` Lynne [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-05-07 11:43 David Fletcher
2022-05-01 23:16 David Fletcher
2022-05-02  7:19 ` Paul B Mahol
2022-05-02 17:41   ` David Fletcher
2022-05-02 18:46     ` Neal Gompa
2022-05-02 22:50   ` David Fletcher
2022-05-03 18:34     ` David Fletcher
2022-05-04  2:16       ` Andreas Rheinhardt
2022-05-02  9:47 ` Nicolas George
2022-05-02 17:45   ` David Fletcher
2022-05-02 18:36     ` Timo Rothenpieler
2022-05-02 19:24     ` Martin Storsjö

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=N1Pce7r--3-2@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git