From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EB17404BD for ; Fri, 25 Mar 2022 19:55:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A527D68B203; Fri, 25 Mar 2022 21:55:08 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8484668B074 for ; Fri, 25 Mar 2022 21:55:02 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 06FED10602F6 for ; Fri, 25 Mar 2022 19:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1648238101; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=Ek4uNynFgKGqYUit47SwpGniCP0Opekr+cC4fGhwfvQ=; b=aVGY5aRYL9QR5wWRvvM9sr5cAD7F/fch0Qsh6fnHS0cm7ylr9M9JatznHskFnnGf FGew9aab6Ap7pnovU5XuvdsaIg5nFZYQ0e+v+P/dR0xmXv8m/qA8h560wzWUay++chA mnPF0QG36r2QvYvoq5Epewi2yX35o5GnbXkDELh22mDa+b3asnvgqZ9w0+1OaQg+Ami r6bkAd979TdtAvU6WKoqMXtQMAGTQ62XsAJqJmFn0VzG6C++cpo+ceeUFlvqc2K3cZx IdtBxOBG6vM3E5flJUgDztR2yRzRVy1Qssu9+2Gc27GnjXaE5KPrIo04yWivUYRN+2w WCOsOqcQhg== Date: Fri, 25 Mar 2022 20:55:01 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <24f1e01f-de12-7180-4353-949760753c4d@martin.st> References: <20220317185819.466470-1-bavison@riscosopen.org> <20220325185257.513933-1-bavison@riscosopen.org> <20220325185257.513933-7-bavison@riscosopen.org> <24f1e01f-de12-7180-4353-949760753c4d@martin.st> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 06/10] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: 25 Mar 2022, 20:49 by martin@martin.st: > On Fri, 25 Mar 2022, Lynne wrote: > >> 25 Mar 2022, 19:52 by bavison@riscosopen.org: >> >>> +@ VC-1 in-loop deblocking filter for 4 pixel pairs at boundary of vertically-neighbouring blocks >>> +@ On entry: >>> +@ r0 -> top-left pel of lower block >>> +@ r1 = row stride, bytes >>> +@ r2 = PQUANT bitstream parameter >>> +function ff_vc1_v_loop_filter4_neon, export=1 >>> + sub r3, r0, r1, lsl #2 >>> + vldr d0, .Lcoeffs >>> + vld1.32 {d1[0]}, [r0], r1 @ P5 >>> + vld1.32 {d2[0]}, [r3], r1 @ P1 >>> + vld1.32 {d3[0]}, [r3], r1 @ P2 >>> + vld1.32 {d4[0]}, [r0], r1 @ P6 >>> + vld1.32 {d5[0]}, [r3], r1 @ P3 >>> + vld1.32 {d6[0]}, [r0], r1 @ P7 >>> + vld1.32 {d7[0]}, [r3] @ P4 >>> + vld1.32 {d16[0]}, [r0] @ P8 >>> >> >> Nice patches, but 2 notes so far: >> > > Indeed, the first glance seems great so far, I haven't applied and poked them closer yet. > >> What's with the weird comment syntax used only in this commit? >> > > In 32 bit arm assembly, @ is a native assembler comment character, and lots of our existing 32 bit assembly uses that so far. > >> Different indentation style used. We try to indent our Arm assembly to: >> <8 spaces>. >> > > Hmm, I haven't applied this patch locally and checked yet, but at least from browsing just the patch, it seems to be quite correctly indented? > > We already discussed this in the previous iteration of his patchset, and the cover letter mentioned that he had fixed it to match the convention now. (And even in the previous iteration, the 32 bit assembly matched the existing code.) > Oh, right, my email client mangled them. All looks good to me then. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".