Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: update for new tone mapping API
Date: Fri, 25 Mar 2022 13:50:51 +0100 (CET)
Message-ID: <Mz07Hj2--3-2@lynne.ee> (raw)
In-Reply-To: <20220325122739.55611-1-ffmpeg@haasn.xyz>

25 Mar 2022, 13:27 by ffmpeg@haasn.xyz:

> From: Niklas Haas <git@haasn.dev>
>
> Upstream gained a new tone-mapping API, which we never switched to. We
> don't need a version bump for this because it was included as part of
> the v4.192 release we currently already depend on.
>
> The "tonemapping" was changed from an enum to a string, owing to the new
> (extensible) upstream tone mapping infrastructure. The old names still
> map cleanly to the new API, so this shouldn't break any typical users.
>
> Some of the remaining options can be moderately approximated with the
> new API, but specifically "desaturation_base" and "max_boost" cannot.
> Remove these entirely, rather than deprecating them. They have been
> non-functional for a while as a result of the upstream deprecation.
>
> Signed-off-by: Niklas Haas <git@haasn.dev>
>

I'm sorry, but I can't accept that. The old API was well-exposed with all
its values available to the user via established methods.
Requiring a user to run once just to know all the available option is
reserved for the dumbest possible APIs like v4l2 and we shouldn't
be adding more of the same to encourage libraries to be lazy
with exposing options in the API.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-03-25 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 12:27 Niklas Haas
2022-03-25 12:50 ` Lynne [this message]
2022-03-25 15:11   ` [FFmpeg-devel] [PATCH v2] " Niklas Haas
2022-03-31 11:25     ` Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Mz07Hj2--3-2@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git