From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl
Date: Tue, 22 Mar 2022 16:35:37 +0100 (CET)
Message-ID: <MymGE6c--3-2@lynne.ee> (raw)
In-Reply-To: <20220319172645.82718-3-leo.izen@gmail.com>
19 Mar 2022, 18:26 by leo.izen@gmail.com:
> This commit adds encoding support to libavcodec
> for Jpeg XL images via the external library libjxl.
> ---
> configure | 3 +-
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/libjxlenc.c | 386 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 390 insertions(+), 1 deletion(-)
> create mode 100644 libavcodec/libjxlenc.c
>
I can't accept this as-is, so NAK.
The coding style needs to be fixed.
And you must remove the sneaky MAINTAINERS change to get yourself
push access. We made that against the rules, which you've clearly read
before submitting the patchset, right?
Then I'll spare time to look at it and merge it myself.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-22 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 17:26 [FFmpeg-devel] [PATCH v7 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser Leo Izen
2022-03-19 17:26 ` [FFmpeg-devel] [PATCH v7 2/5] avcodec/libjxl: add Jpeg XL decoding via libjxl Leo Izen
2022-03-19 17:26 ` [FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding " Leo Izen
2022-03-22 15:35 ` Lynne [this message]
2022-03-22 15:52 ` Marvin Scholz
2022-03-22 19:37 ` Leo Izen
2022-03-19 17:26 ` [FFmpeg-devel] [PATCH v7 4/5] avformat/image2: add Jpeg XL as image2 format Leo Izen
2022-03-23 11:38 ` Anton Khirnov
2022-03-23 13:14 ` Leo Izen
2022-03-19 17:26 ` [FFmpeg-devel] [PATCH v7 5/5] fate/jpegxl: add JPEG XL demux and parse FATE test Leo Izen
2022-03-23 11:36 ` [FFmpeg-devel] [PATCH v7 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser Anton Khirnov
2022-03-23 13:14 ` Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MymGE6c--3-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git