From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5C1AA41115 for ; Wed, 16 Mar 2022 12:39:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B8BE68AF88; Wed, 16 Mar 2022 14:39:48 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B43C68AE9E for ; Wed, 16 Mar 2022 14:39:42 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 1A91F10602D4 for ; Wed, 16 Mar 2022 12:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1647434382; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=R2T4R+vp1Rf6J0u9IpAbwJ+srdY30fr1ZfKHZjefivM=; b=a3qFQxx6DzrU+kEXhTuzRrhZ0tJ1Fy3BNC/OUMN3fSoHzHiuF/cDnoO0hCglWv+4 ppQiy+cVo6ogMST9LSV0w4ACjIIOvt3izWUuAd5UmTqVtj5ZveqYMA8DzdjpoifE08G DtSHoAmFScpdYXvPIBnstEGCOoBXLGSo+WFveMIX9n0J2RF1o0wVx2jEqejmwCr7x06 lz9e5TdYju1tYU08VrfhzzSSDbt2IffZ4BzZM8wsAmpEcNiKfrN5x9jNMJUlM33kJbN xMd/l9UN52X9a1BUxO992pc4lXA/eVL36gxxFt2oeZFTpCbZczV2DU7oeGYD/4JNsit MPyP5rGeBQ== Date: Wed, 16 Mar 2022 13:39:42 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20220316120759.2292546-1-danilchap@google.com> References: <20220316120759.2292546-1-danilchap@google.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: 16 Mar 2022, 13:07 by danilchap-at-google.com@ffmpeg.org: > --- > libavcodec/libvpxenc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 8f94ba15dc..45baeed435 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -1658,6 +1658,13 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, > flags |= strtoul(en->value, NULL, 10); > } > > + en = av_dict_get(frame->metadata, "max-quantizer", NULL, 0); > + if (en) { > + struct vpx_codec_enc_cfg cfg = *enccfg; > + cfg.rc_max_quantizer = strtoul(en->value, NULL, 10); > + vpx_codec_enc_config_set(&ctx->encoder, &cfg); > + } > I was going to NAK the earlier patch, but forgot. Please think of a better way than stuffing random data in inappropriate fields, and fix the earlier patch that was mistakenly merged to not do that. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".