Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV option

[Lynne <dev@lynne.ee>]

18 Feb 2022, 16:24 by toqsxw@outlook.com:

>> 29 Jan 2022, 13:34 by toqsxw at outlook.com:
>>
>>> Ping.
>>>
>>>> From: Wu, Jianhua<mailto:jianhua.wu-at-intel.com at ffmpeg.org>
>>>> Sent: 2022年1月21日 19:42
>>>> To: ffmpeg-devel at ffmpeg.org<mailto:ffmpeg-devel at ffmpeg.org>
>>>> Cc: Wu, Jianhua<mailto:jianhua.wu at intel.com>
>>>> Subject: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV option
>>>>
>>>> [PATCH 1/5] avfilter/vf_gblur_vulkan: add sizeV option [PATCH 2/5] avfilter:add shader_vulkan filter [PATCH 3/5] avfilter/vf_blend_vulkan: add multiply blend mode [PATCH 4/5] avutil/vulkan: don't use strlen as loop >condition [PATCH 5/5] avfilter/scale_vulkan: use RET for checking return value
>>>>
>>>> Patches attached.
>>>>
>>>
>>> Hi there,
>>>
>>> Any update?
>>>
>>
>> Sorry, haven't forgotten, but been busy with FFTs lately.
>> Will try to review and test the patches soon.
>>
>
> Hi there,
>
> I'm sorry for bothering you. If there is any update on this
> thread, please do let me know. 
>

Pushed all except the strlen() in a loop condition and the shader filter.
I pushed a different, smaller version for the strlen patch.

As for a shader filter, I'd like something that's a lot less minimal.
You should expose the frame number, framerate (with an avoption to set it),
pixel format to the shader. Keep in mind the API will be fixed, so
we need to get this right the first time hopefully.
Also, correct the name style. We don't use camelcase for variables,
and we use "av_" instead of "ff_" for public API, which a shader sort of is IMO.
You should expose alpha planes as well.
Finally, could you implement N-inputs and M-outputs, configurable via
avoptions? That way, someone could make a custom blend filter without
a separate avfilter which takes multiple inputs. Or a separator filter.
Or a simple source filter that just produces an image pattern.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".