Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.
Date: Wed, 2 Feb 2022 10:55:09 +0100 (CET)
Message-ID: <Mutqzr0--3-2@lynne.ee> (raw)
In-Reply-To: <CAPd6JnF+FU-jz7s59w1+KjA=gSUXEhokqXuDjk=LZVVRoeC+pw@mail.gmail.com>

2 Feb 2022, 03:51 by markg85@gmail.com:

> On Wed, Feb 2, 2022 at 3:29 AM Lynne <dev@lynne.ee> wrote:
>
>> 1 Feb 2022, 22:58 by markg85@gmail.com:
>>
>> > This patch adds support for:
>> > - ffplay ipfs://<cid>
>> > - ffplay ipns://<cid>
>> >
>> > IPFS data can be played from so called "ipfs gateways".
>> > A gateway is essentially a webserver that gives access to the
>> > distributed IPFS network.
>> >
>> > This protocol support (ipfs and ipns) therefore translates
>> > ipfs:// and ipns:// to a http:// url. This resulting url is
>> > then handled by the http protocol. It could also be https
>> > depending on the gateway provided.
>> >
>> > To use this protocol, a gateway must be provided.
>> > If you do nothing it will try to find it in your
>> > $HOME/.ipfs/gateway file. The ways to set it manually are:
>> > 1. Define a -gateway <url> to the gateway.
>> > 2. Define $IPFS_GATEWAY with the full http link to the gateway.
>> > 3. Define $IPFS_PATH and point it to the IPFS data path.
>> > 4. Have IPFS running in your local user folder (under $HOME/.ipfs).
>> >
>> > Signed-off-by: Mark Gaiser <markg85@gmail.com>
>> > ---
>> >  configure                 |   2 +
>> >  doc/protocols.texi        |  30 +++++
>> >  libavformat/Makefile      |   2 +
>> >  libavformat/ipfsgateway.c | 267 ++++++++++++++++++++++++++++++++++++++
>> >  libavformat/protocols.c   |   2 +
>> >  5 files changed, 303 insertions(+)
>> >  create mode 100644 libavformat/ipfsgateway.c
>> >
>>
>> Fix all the coding style issues first...
>>
> Any hints on those? As I thought it was matching the other files (looking
> at crypto.c) nicely.
>

https://ffmpeg.org/developer.html#Coding-Rules-1
And we also don't wrap single-line statements in blocks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".