From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] lavc: deprecate FF_IDCT_NONE
Date: Tue, 1 Feb 2022 12:16:18 +0100 (CET)
Message-ID: <Muozyp8--3-2@lynne.ee> (raw)
In-Reply-To: <20220201100227.18928-4-anton@khirnov.net>
1 Feb 2022, 11:02 by anton@khirnov.net:
> It was only used by XvMC.
> ---
> libavcodec/avcodec.h | 5 ++++-
> libavcodec/idctdsp.c | 1 -
> libavcodec/version.h | 1 +
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index acb7ae0e14..5362446092 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1407,7 +1407,10 @@ typedef struct AVCodecContext {
> #define FF_IDCT_SIMPLEARMV6 17
> #define FF_IDCT_FAAN 20
> #define FF_IDCT_SIMPLENEON 22
> -#define FF_IDCT_NONE 24 /* Used by XvMC to extract IDCT coefficients with FF_IDCT_PERM_NONE */
> +#if FF_API_IDCT_NONE
> +// formerly used by xvmc
> +#define FF_IDCT_NONE 24
> +#endif
> #define FF_IDCT_SIMPLEAUTO 128
>
Isn't this a private define that clients weren't meant to use?
If so, may as well drop it with patch #1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-01 11:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 10:02 [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code Anton Khirnov
2022-02-01 10:02 ` [FFmpeg-devel] [PATCH 2/4] lavc/xvmc.h: mark the header as deprecated Anton Khirnov
2022-02-01 10:02 ` [FFmpeg-devel] [PATCH 3/4] lavu/pixfmt: deprecate AV_PIX_FMT_XVMC Anton Khirnov
2022-02-01 10:02 ` [FFmpeg-devel] [PATCH 4/4] lavc: deprecate FF_IDCT_NONE Anton Khirnov
2022-02-01 11:16 ` Lynne [this message]
2022-02-01 11:32 ` James Almer
2022-02-07 1:46 ` [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code Andreas Rheinhardt
2022-02-07 1:53 ` James Almer
2022-02-07 2:18 ` Soft Works
2022-02-08 9:36 ` Anton Khirnov
2022-02-08 21:34 ` Soft Works
2022-02-09 5:49 ` Anton Khirnov
2022-02-09 6:19 ` Soft Works
2022-02-09 6:38 ` Anton Khirnov
2022-02-08 9:37 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Muozyp8--3-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git