From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B4DA40837 for ; Mon, 31 Jan 2022 20:26:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C8DA68B1AC; Mon, 31 Jan 2022 22:26:50 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E281C68B0A0 for ; Mon, 31 Jan 2022 22:26:43 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 7432410602EC for ; Mon, 31 Jan 2022 20:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1643660803; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=X2EDs5e3jfVvUUuYHzxBDgaZgceREYMhsjP2YKkx27k=; b=QE/MHXZAG+s/D7w54eHVPadnpsH2PBAVo44iQ62/Hz/bUfffeCXE4LY7Ct/eCk3f K/8AWpHEX34SjUuyT6AVmGDIcyJEpK9zSdmaVojlqxBnxddPecMIlHFsu7IMwr4vuh3 5wc+CtnnnxKT9emAJR4CIUDoK+lI73zDrk//QT3xAiwRGiRla/Sy2AvlmccrFTJQZvD gMtVNDUaFqv5XMcgWtyCwW1AL6eAOoO7o7tAhuQck+nFFwASeNvVSQ//mnaBUDJdpJE PTIgsWdRUDETTvDL2JrF/9sUNqv5CG0BJegXsRR9KG6H4LEGfqhNqZCz40h5+ZZ20Rx o/9BHQkXBg== Date: Mon, 31 Jan 2022 21:26:43 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20220131135116.14035-2-markg85@gmail.com> References: <20220131135116.14035-1-markg85@gmail.com> <20220131135116.14035-2-markg85@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/5] Early version of IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jan 31, 2022, 14:51 by markg85@gmail.com: > Signed-off-by: Mark Gaiser > --- > configure | 1 + > doc/protocols.texi | 30 ++++++ > libavformat/Makefile | 1 + > libavformat/ipfs.c | 202 ++++++++++++++++++++++++++++++++++++++++ > libavformat/protocols.c | 2 + > 5 files changed, 236 insertions(+) > create mode 100644 libavformat/ipfs.c > > + > +static int ipfs_open(URLContext *h, const char *uri, int flags, AVDictionary **options) > +{ > + const char *gatewaysuffix; > + int ret = 0; > + Context *c = h->priv_data; > + > + if (!av_strstart(uri, "ipfs://", &gatewaysuffix) && > + !av_strstart(uri, "ipfs:", &gatewaysuffix)) { > + av_log(h, AV_LOG_ERROR, "Unsupported url %s\n", uri); > + ret = AVERROR(EINVAL); > + goto err; > + } > + > + char* ipfs_gateway = "https://ipfs.io/ipfs/"; > That's a no from me. I'd rather have native support rather than depend on some third party service. Users can just convert the link themselves if they want to. Surely the IPFS project has libraries one could use instead. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".