From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 801C0406BC for ; Fri, 28 Jan 2022 07:07:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7083668B232; Fri, 28 Jan 2022 09:07:44 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB81768B186 for ; Fri, 28 Jan 2022 09:07:37 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 11BFE10602D9 for ; Fri, 28 Jan 2022 07:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1643353656; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=MuBXaZv3wjsf5HUruotFVXBxEsCMs+dtxpf9uDFIqKo=; b=JKCkqx5NyCUC491kdgoBBG+Srn6hEA4k/pcti5ieN9OXyTtwHLo+0+uZuo8yafOu rktMvvFb4IvwoSThroagOI0mVP6U7sTGRES4iVevQVQGdsJQOzTydQLoddXx0GTvs1j 6Zjqq1hd4ANb0Wt+XjCzvUYanB5BXQEAa9SY2E2p5yNE95QRCeqoDMRUGmphK2Lm4+V OcRQgUDCUj+Hm24OpAB8dm/sE+JjmBUjyhc/VXJl/kr+io9kPrPIThqkxjEfUpJOpUx lC1Rm8uqjRp1L9tvWMf6Buij+MtVVzbakEbiq7EdwDLlOooFjNgKhld7Vq5gf7xqfvc GzIKF5AsCg== Date: Fri, 28 Jan 2022 08:07:36 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20220128020818.39850-1-lq@chinaffmpeg.org-MuTRYJS--3-2> References: <20220128020818.39850-1-lq@chinaffmpeg.org> <20220128020818.39850-1-lq@chinaffmpeg.org-MuTRYJS--3-2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/tx: remove deadcode of the control flow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: 28 Jan 2022, 03:08 by lq@chinaffmpeg.org: > From: Steven Liu > > Fix CID: 1497864 > The control flow should return ENOSYS if nb_cd_matches is 0 at before > and the ret equal AVERROR(ENOMEM) or goto end label, so remove the last > control flow if (ret >= 0) before end label. > > Signed-off-by: Steven Liu > --- > libavutil/tx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavutil/tx.c b/libavutil/tx.c > index 2897f3bd35..50616adba7 100644 > --- a/libavutil/tx.c > +++ b/libavutil/tx.c > @@ -601,9 +601,6 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum AVTXType type, > > av_free(sub); > > - if (ret >= 0) > - ret = AVERROR(ENOSYS); > - > end: > av_free(cd_matches); > return ret; > Sorry, neither of those is correct. I'll push my own. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".