Re: [FFmpeg-devel] [PATCH 1/2] avutil/tx: remove deadcode of the control flow

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/tx: remove deadcode of the control flow
Date: Fri, 28 Jan 2022 08:07:36 +0100 (CET)
Message-ID: <MuUVgkt--3-2@lynne.ee> (raw)
In-Reply-To: <20220128020818.39850-1-lq@chinaffmpeg.org-MuTRYJS--3-2>

28 Jan 2022, 03:08 by lq@chinaffmpeg.org:

> From: Steven Liu <liuqi05@kuaishou.com>
>
> Fix CID: 1497864
> The control flow should return ENOSYS if nb_cd_matches is 0 at before
> and the ret equal AVERROR(ENOMEM) or goto end label, so remove the last
> control flow if (ret >= 0) before end label.
>
> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
> ---
>  libavutil/tx.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/libavutil/tx.c b/libavutil/tx.c
> index 2897f3bd35..50616adba7 100644
> --- a/libavutil/tx.c
> +++ b/libavutil/tx.c
> @@ -601,9 +601,6 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum AVTXType type,
>  
>  av_free(sub);
>  
> -    if (ret >= 0)
> -        ret = AVERROR(ENOSYS);
> -
>  end:
>  av_free(cd_matches);
>  return ret;
>

Sorry, neither of those is correct.
I'll push my own.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".