From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97E794054E for ; Tue, 25 Jan 2022 10:46:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D9D3568B00D; Tue, 25 Jan 2022 12:46:48 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A58B68AF2E for ; Tue, 25 Jan 2022 12:46:43 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 60E5210600E3 for ; Tue, 25 Jan 2022 10:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1643107602; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=Mj17WJokenrbWoxTKJfFk2aIlx2sEZS0RhRNnSwLzu0=; b=xaOGN7IuV5eNWU0adK74Gz4SbeYAXdvYWKEX4t+B1+LGYigQ+bOsXWDQTuSSXnEc oQYmmt4u7K4cyQpmafckYZRWLLLWfTXMj0WmC3wk44eO4/Gn36a+HgjUKguCQP0aASi yTSvqOE0fRfMtnf8jCRlCrRN5NgKbr8GSGwD5bVwApE6e0gLva17O0oJBcogkTQxsqs VrlILRddt2V+qDiSvrVJN3U81k780H6MizCoEZpLutAXN9XC38KcOvwKunOgjdSZiSD zjJAUIAC3tOHyUW3vCM0jdkkCGebQuvpyblr45qePPfvQ29CcrmQqgBf4RfqWyg6Nwa 9typhJL01w== Date: Tue, 25 Jan 2022 11:46:42 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: 21 Jan 2022, 09:51 by dev@lynne.ee: > 21 Jan 2022, 09:33 by dev@lynne.ee: > >> This commit rewrites the internal transform code into a constructor >> that stitches transforms (codelets). >> This allows for transforms to reuse arbitrary parts of other >> transforms, and allows transforms to be stacked onto one >> another (such as a full iMDCT using a half-iMDCT which in turn >> uses an FFT). It also permits for each step to be individually >> replaced by assembly or a custom implementation (such as an ASIC). >> >> Patch attached. >> > > Forgot that I disabled double and int32 transforms to speed up > testing, reenabled locally and on my github tx_tree branch. > Also removed some inactive debug code. > https://github.com/cyanreg/FFmpeg/tree/tx_tree > I fixed bugs and improved to code more, and I think it's ready for merging now. The rdft is no longer bound by any convention, and its scale may be changed by the user, eliminating after-transform multiplies that are used pretty much everywhere in our code. If someone (looks at Paul) gives it a test or converts a filter, would be nice. I've only tested it on my synthetic benchmarks: https://github.com/cyanreg/lavu_fft_test I plan to push the patchset tomorrow unless there are comments. Mostly done with the aarch64's SIMD, patch coming soon, hopefully. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".