From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor
Date: Tue, 25 Jan 2022 11:46:42 +0100 (CET)
Message-ID: <MuFq3r2--3-2@lynne.ee> (raw)
In-Reply-To: <MtvpRbN--3-2@lynne.ee-MtvpUzJ--7-2>
21 Jan 2022, 09:51 by dev@lynne.ee:
> 21 Jan 2022, 09:33 by dev@lynne.ee:
>
>> This commit rewrites the internal transform code into a constructor
>> that stitches transforms (codelets).
>> This allows for transforms to reuse arbitrary parts of other
>> transforms, and allows transforms to be stacked onto one
>> another (such as a full iMDCT using a half-iMDCT which in turn
>> uses an FFT). It also permits for each step to be individually
>> replaced by assembly or a custom implementation (such as an ASIC).
>>
>> Patch attached.
>>
>
> Forgot that I disabled double and int32 transforms to speed up
> testing, reenabled locally and on my github tx_tree branch.
> Also removed some inactive debug code.
> https://github.com/cyanreg/FFmpeg/tree/tx_tree
>
I fixed bugs and improved to code more, and I think it's ready
for merging now.
The rdft is no longer bound by any convention, and its
scale may be changed by the user, eliminating after-transform
multiplies that are used pretty much everywhere in our code.
If someone (looks at Paul) gives it a test or converts a filter,
would be nice. I've only tested it on my synthetic benchmarks:
https://github.com/cyanreg/lavu_fft_test
I plan to push the patchset tomorrow unless there are comments.
Mostly done with the aarch64's SIMD, patch coming soon, hopefully.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-25 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 8:33 Lynne
[not found] ` <Mtvl7g3--3-2@lynne.ee-MtvlCNf----2>
2022-01-21 8:34 ` [FFmpeg-devel] [PATCH 2/2] lavu/tx: add an RDFT implementation Lynne
2022-01-21 8:51 ` [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor Lynne
[not found] ` <MtvpRbN--3-2@lynne.ee-MtvpUzJ--7-2>
2022-01-25 10:46 ` Lynne [this message]
2022-01-25 17:17 ` Paul B Mahol
2022-01-26 3:31 ` Lynne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MuFq3r2--3-2@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git