From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A001541018 for ; Sun, 2 Jan 2022 18:18:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C0EBA68B164; Sun, 2 Jan 2022 20:18:13 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 06FFF68AFD1 for ; Sun, 2 Jan 2022 20:18:07 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id A9B4C106015C for ; Sun, 2 Jan 2022 18:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1641147486; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=zHaPDHzQE8WbjA4DeFtrWchbSp/UkN/x8hXX3N7I1dQ=; b=d1nuUvpw7rX456+genaPRqhDSerSwwYS+/glO/sLfP9A9e10fmwHNuAzE1kXqBxp VkHWAHJVA7Ui3smUAOYUmKFFmFMObseGV+MJYgiwMOrjDx1tKkEilf+A0ZRCJ/KqoKI 4+GGHBP9fwc4CXN6uT+U5783AaB2EeISINEIXdWimLRZlD+Vk3tUT7TmIsIp4M0dCq0 9rZSXvL6qBorEJPqw12eeDOdgUEEA7OwU87OWnfeOajq5JkSFXDxujcxF5HvoociHTg m38Je7Q3NHVxKMF4aWylCCxj/IYD5M721/ELxFnL8GhnmTBBbLMZRt8GSoWsYgMXilP NLZdPUBJVg== Date: Sun, 2 Jan 2022 19:18:06 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20220102174605.2438-1-anton@khirnov.net-MsQtgJZ----2> References: <20220102174605.2438-1-anton@khirnov.net> <20220102174605.2438-1-anton@khirnov.net-MsQtgJZ----2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [RFC/PATCH 1/2] lavf: add a flag for experimental (de)muxers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: 2 Jan 2022, 18:46 by anton@khirnov.net: > --- > doc/APIchanges | 3 +++ > libavformat/avformat.h | 7 +++++++ > libavformat/format.c | 2 ++ > libavformat/version.h | 2 +- > 4 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 670a59329e..29c235630e 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -14,6 +14,9 @@ libavutil: 2021-04-27 > > API changes, most recent first: > > +2022-01-xx - xxxxxxxxxx - lavf 59.13.100 - avformat.h > + Add AVFMT_EXPERIMENTAL flag. > + > 2021-12-xx - xxxxxxxxxx - lavu 57.13.100 - hwcontext_videotoolbox.h > Add av_vt_pixbuf_set_attachments > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 70b36d7682..6ce367e854 100644 > --- a/libavformat/avformat.h > +++ b/libavformat/avformat.h > @@ -463,6 +463,13 @@ typedef struct AVProbeData { > /// Demuxer will use avio_open, no opened file should be provided by the caller. > #define AVFMT_NOFILE 0x0001 > #define AVFMT_NEEDNUMBER 0x0002 /**< Needs '%d' in filename. */ > +/** > + * The muxer/demuxer is experimental and should be used with caution. > + * > + * - demuxers: will not be selected automatically by probing, must be specified > + * explicitly. > + */ > +#define AVFMT_EXPERIMENTAL 0x0004 > #define AVFMT_SHOW_IDS 0x0008 /**< Show format stream IDs numbers. */ > #define AVFMT_GLOBALHEADER 0x0040 /**< Format wants global header. */ > #define AVFMT_NOTIMESTAMPS 0x0080 /**< Format does not need / have any timestamps. */ > diff --git a/libavformat/format.c b/libavformat/format.c > index 387627009e..52b85c16a2 100644 > --- a/libavformat/format.c > +++ b/libavformat/format.c > @@ -158,6 +158,8 @@ const AVInputFormat *av_probe_input_format3(const AVProbeData *pd, > } > > while ((fmt1 = av_demuxer_iterate(&i))) { > + if (fmt1->flags & AVFMT_EXPERIMENTAL) > + continue; > if (!is_opened == !(fmt1->flags & AVFMT_NOFILE) && strcmp(fmt1->name, "image2")) > continue; > score = 0; > diff --git a/libavformat/version.h b/libavformat/version.h > index 917b9ffa5d..29dcce352b 100644 > --- a/libavformat/version.h > +++ b/libavformat/version.h > @@ -32,7 +32,7 @@ > // Major bumping may affect Ticket5467, 5421, 5451(compatibility with Chromium) > // Also please add any ticket numbers that you believe might be affected here > #define LIBAVFORMAT_VERSION_MAJOR 59 > -#define LIBAVFORMAT_VERSION_MINOR 12 > +#define LIBAVFORMAT_VERSION_MINOR 13 > #define LIBAVFORMAT_VERSION_MICRO 100 > > #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \ > You should add it in libavformat/options_table.h too. Apart from that, it looks fine. Should we move muxers previously behind strict_std_compliance > experimental like scd behind this flag or would that be an API breakage? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".