From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 77F12403B6 for ; Mon, 20 Dec 2021 17:45:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E3AEA68AF97; Mon, 20 Dec 2021 19:45:50 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0F66268A8EE for ; Mon, 20 Dec 2021 19:45:43 +0200 (EET) Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 59F691060154 for ; Mon, 20 Dec 2021 17:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640022343; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=+/jsSVMq1lQhROmSEdOB72SK/WI9oznG3H4EDIryPOw=; b=ceo6s8WXRc3EXc3khZq/IvgkeLYDPv56lgguGUD0a95e+ynwlQWpLDAT0XqOu337 /R6DMiF0564B8gJXTfEXPDiIEGex50BaKuIhlVhQRiHijTlzW/S8CT+UQOTWj66i8mP lWR4dn7Yh3ZBR7btIZ5FiuT7NFL79cnv98hLJr7C0iMkX4O6/SYv7UVCxG8Dg+uvkLd GUVdC8GOaSgkbV0D7XpLzS2vAdOSzIETYRIDlFuZ7fu0xk0ogyvjZch6H523H7++0KD wXOjRYTDu38eOQoFOuHjQFYodSvlGDUAD8jAVO/RYMAHQmFYzRuE/YzaOqReg24qilc MEof3jQs4w== Date: Mon, 20 Dec 2021 18:45:43 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20211220165957.GV2829255@pb2> References: <20211220165957.GV2829255@pb2> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_170908_1519444429.1640022343164" Subject: Re: [FFmpeg-devel] [PATCH] configure: autodetect vulkan X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ------=_Part_170908_1519444429.1640022343164 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit 20 Dec 2021, 17:59 by michael@niedermayer.cc: > On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote: > >> Recently, Metal support was merged, which is autodetected >> by default. Metal doesn't even have a hwcontext and it's not >> a hwaccel, nor would it likely ever be one as Apple won't drop >> videotoolbox. >> >> To keep it fair, autodetect Vulkan, which is a hwcontext, >> and for which there is an unmerged hwaccel patch. >> >> Patch attached. >> >> configure | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> 09c6bfd367bd2ac897abc5716e2e9605341036cd 0001-configure-autodetect-vulkan.patch >> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Mon, 20 Dec 2021 11:04:49 +0100 >> Subject: [PATCH] configure: autodetect vulkan >> > > breaks build here on ubuntu > > ./configure > ERROR: defined VK_VERSION_1_2 not satisfied > > If you think configure made a mistake, make sure you are using the latest > version from Git. If the latest version fails, report the problem to the > ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat. > Include the log file "ffbuild/config.log" produced by configure as this will help > solve the problem. > Thanks for testing, V2 attached, just changes require_cpp to check_cpp, since autodetecting is not a hard-require unlike enabling libraries. ------=_Part_170908_1519444429.1640022343164 Content-Type: text/x-patch; charset=us-ascii; name=v2-0001-configure-autodetect-vulkan.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=v2-0001-configure-autodetect-vulkan.patch >From 57086023a05a981609f68f7760e1398b3211e0ab Mon Sep 17 00:00:00 2001 From: Lynne Date: Mon, 20 Dec 2021 11:04:49 +0100 Subject: [PATCH v2] configure: autodetect vulkan --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index d8b07c8e00..3be4de61e0 100755 --- a/configure +++ b/configure @@ -324,7 +324,7 @@ External library support: --disable-securetransport disable Secure Transport, needed for TLS support on OSX if openssl and gnutls are not used [autodetect] --enable-vapoursynth enable VapourSynth demuxer [no] - --enable-vulkan enable Vulkan code [no] + --disable-vulkan enable Vulkan code [autodetect] --disable-xlib disable xlib [autodetect] --disable-zlib disable zlib [autodetect] @@ -1896,6 +1896,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST=" vaapi vdpau videotoolbox + vulkan v4l2_m2m xvmc " @@ -1918,7 +1919,6 @@ HWACCEL_LIBRARY_LIST=" mmal omx opencl - vulkan " DOCUMENT_LIST=" @@ -6914,7 +6914,7 @@ enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if. if enabled vulkan; then check_pkg_config_header_only vulkan "vulkan >= 1.2.189" "vulkan/vulkan.h" "defined VK_VERSION_1_2" || - require_cpp_condition vulkan "vulkan/vulkan.h" "defined VK_VERSION_1_2" + check_cpp_condition vulkan "vulkan/vulkan.h" "defined VK_VERSION_1_2" fi if enabled x86; then -- 2.34.1 ------=_Part_170908_1519444429.1640022343164 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ------=_Part_170908_1519444429.1640022343164--