From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3BD8542B4B for ; Tue, 26 Apr 2022 03:10:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D861968B2AF; Tue, 26 Apr 2022 06:09:57 +0300 (EEST) Received: from mx0a-00428a01.pphosted.com (mx0a-00428a01.pphosted.com [205.220.165.14]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9988768AF9F for ; Tue, 26 Apr 2022 06:09:50 +0300 (EEST) Received: from pps.filterd (m0243507.ppops.net [127.0.0.1]) by mx0b-00428a01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23PFhaQs015916 for ; Mon, 25 Apr 2022 23:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bose.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps1; bh=LJxm6D1RWLfJ6pSCjmq+pI3B9A/hN34w/KfDkPnZwPQ=; b=X4YViQnV+hBUjWsLVw85lp0YHJIlG4VH1/odsg+edoj/5R8Xg8ZjcB1Md+M1EyqFCGl9 KQbxKq0pp/C7hk2uQPfvU043ejYfC/s2zwWNaJk1SsgSi44F0/GbNShrIdS/wr2/l8NZ 3wA43DN/rtsH1N0B6cjdFpJDHfIi+8vrJ+/D5ZMuEHXM63bJz7B1FJyysLvG7C2zOmzw 1/YCUiVf9YxYbcoO71B3AmYUGh1AAxPSI3EB7RyEuQKugmCUd0ve2MGklWopsgyge0jg DssXZS38pEPiTUCban5C4cKlBk06ym5uGVuZWX9lsn6Yw6lI5fuhhxsFtc0QYkWJvxb6 ew== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by mx0b-00428a01.pphosted.com (PPS) with ESMTPS id 3fmbgrbct7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 25 Apr 2022 23:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bose.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJxm6D1RWLfJ6pSCjmq+pI3B9A/hN34w/KfDkPnZwPQ=; b=or3a5mPPklm9lO9wxTg+cKyGDxOaEqMliwudluE+qjSShJZsTO9tBy9EfHUxVaBSNwKHxgp3WIYkvyScATTeB+VdasGeobp2xCDAAnaca1LB1rTlpsMAnpLUIOfKmolPzKAkX3kMieIKPz1wKpzT4+9xWufixyxkxiW/DTYsdmM= Received: from MW4PR04CA0134.namprd04.prod.outlook.com (2603:10b6:303:84::19) by CO3PR08MB7912.namprd08.prod.outlook.com (2603:10b6:303:17b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr 2022 03:09:44 +0000 Received: from MW2NAM10FT037.eop-nam10.prod.protection.outlook.com (2603:10b6:303:84:cafe::83) by MW4PR04CA0134.outlook.office365.com (2603:10b6:303:84::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Tue, 26 Apr 2022 03:09:44 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 34.202.228.63) smtp.mailfrom=bose.com; dkim=pass (signature was verified) header.d=bose.com;dmarc=pass action=none header.from=bose.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning bose.com discourages use of 34.202.228.63 as permitted sender) Received: from dg1.bose.com (34.202.228.63) by MW2NAM10FT037.mail.protection.outlook.com (10.13.154.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 03:09:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bM9mpAv+T3zx9DqrR2iTfICbLRQOVKPUKpNjlwi/xTStsa/uA6Gaqk4HmJqkB/RbWSVOCKUWmG/Rr5FQIMAxCeSwsdq1udYXPr5lUQpiUJm/P67E4H0qK60PJIBX4fG6Mg6hzwMzzoIsIdylcX6qB5tgfeTp5vstjU7iAwQwpG+ROVXwI83m1SjtIBWW9DbZwv0Vfa46mU2ZJM6CqI+I8Bi/gPM7e0xufA3wCxuFiEDJJBhNo4cRM6m49dPS49w3jQsum3qSddN22cXvPmKhQ9SYC5G84OTJk481pRkl5NXfs5u4jKTrP4T7VJNffR5qvBjrWIDjItZSu1uIC3URUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJxm6D1RWLfJ6pSCjmq+pI3B9A/hN34w/KfDkPnZwPQ=; b=FckWq09T8iItQpbuN8+TnCQ+LVf9HCdvX1OEQi4qts0e9ch7t5BXo9mu9fC5AzAZy5axhbR7uAqYO4OWScT4tJkYmDhNr657bhRqvE0CwZWAPYbaATCKy/RpeTQVR/MNQ/oJt64yXehgES3p8Mqsx+aBCi1GOip2pHDhYHAf9mmd3W3dKD8A0e4AbW+I7rAhsPk1dcwKzwi84R8xu0tVQjtYN+Az4x2L5zjURiRplP9K6zt3UwxrHEFoV30LWUhRD6RLbLvQARkI723hRVkyxs5mod7dfYSpvlIQ7d0Tpb/ubOS7Ky+qEuCRCludruAqXlFKmXAfuQW+sgIpHpS63w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bose.com; dmarc=pass action=none header.from=bose.com; dkim=pass header.d=bose.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bose.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJxm6D1RWLfJ6pSCjmq+pI3B9A/hN34w/KfDkPnZwPQ=; b=or3a5mPPklm9lO9wxTg+cKyGDxOaEqMliwudluE+qjSShJZsTO9tBy9EfHUxVaBSNwKHxgp3WIYkvyScATTeB+VdasGeobp2xCDAAnaca1LB1rTlpsMAnpLUIOfKmolPzKAkX3kMieIKPz1wKpzT4+9xWufixyxkxiW/DTYsdmM= From: "Malviya, Janpriya" To: FFmpeg development discussions and patches Thread-Topic: [PATCH] libavformat/mov.c : Avoid seek request with invalid seek offset ( 9223372036854775799 ) after EOS Thread-Index: AdhWEyc7NcjLMc2bSTyYe3BqgReNoADB5dN+ X-DGNDLP: BoseProcessed1 Date: Tue, 26 Apr 2022 03:09:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_879e395e-e3b5-421f-8616-70a10f9451af_Enabled=True; MSIP_Label_879e395e-e3b5-421f-8616-70a10f9451af_SiteId=0beb0c35-9cbb-4feb-99e5-589e415c7944; MSIP_Label_879e395e-e3b5-421f-8616-70a10f9451af_SetDate=2022-04-22T08:12:35.0000000Z; MSIP_Label_879e395e-e3b5-421f-8616-70a10f9451af_Name=879e395e-e3b5-421f-8616-70a10f9451af; MSIP_Label_879e395e-e3b5-421f-8616-70a10f9451af_ContentBits=0; MSIP_Label_879e395e-e3b5-421f-8616-70a10f9451af_Method=Standard Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bose.com; X-MS-Office365-Filtering-Correlation-Id: 777a1a57-1494-4454-8c5b-08da27323639 x-ms-traffictypediagnostic: DM5PR08MB2825:EE_|MW2NAM10FT037:EE_|CO3PR08MB7912:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CJb6RcewnD0PHWb/L/tYYbpEJVssuQzpiXxvai0OJ9aK3HxmHWuJtkGSUtSKf9jwk5ewtxR4iHlBjC7Ej0JIjGNG2jxO6ZROybuYBjs2UZJ6Id6TNH49kSaiZNAKOJncw2blOM8CmaGJvoL/U7cisz5psXjvdjn8OEo3bNuosz6jk6LSuZc1z6kr/eaS0u8S6e3IgMhgETyWmGBZKKdbDjAP7FbwwlFckgoUdkzRCYeWPot1zuVYbamIfiVDHs5NVWckQ49aOUg4sRAhtLsu9nQ2Mc8bAZmWVVI4eFI7EVlGsT+jSqvHIFPqqpcioUNBjR4wh3EBWkVomgNZkSP/t3o9Vkz2QejI8tuzJPmBM7Avn3lK/TkpfUXp+F4m36RC+2HFJmD3rIQkg8K3eofN3Dyob9rJanC/hDut1A7Fl/ptPKmrilzQfhAZ7B+NKEbVzWpXURybnZGywt5e84RpC2Qp04G3n/dDUZOFnXwzyURiiyzYBrOJU/0OhMJh+0Rc9EIu/3Q6ilmWU/p6AM6v7dPcZHm8HsKF7UebszEs14qGyAVZUuPhakKHHQAcdiw3l+m4J6NJzTGBAtMWaR7PEQvkHAEKCvP76ZIvv9pq3Teq/lR9X8yWAlQcDXgNoFUMzkg5wvd+L+cZpvdbt1LyRwRKtM9hIv/0bCEjPFHhGJuj3jHMcE9RYHruaygJrso2lgYfBj/NbIrUAalxLeC42XLq+yZ9GCkHCawJ12iiMyo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR08MB2655.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(38100700002)(66556008)(38070700005)(86362001)(508600001)(6916009)(54906003)(26005)(9686003)(71200400001)(76116006)(91956017)(66946007)(122000001)(4326008)(8676002)(33656002)(66476007)(64756008)(53546011)(66446008)(52536014)(8936002)(5660300002)(6506007)(7696005)(83380400001)(107886003)(2906002)(186003)(55016003)(116584003); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR08MB2825 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: MW2NAM10FT037.eop-nam10.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b7d0badc-d264-446f-7804-08da273234a5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pV4iVBWvSoCweSi6Um3QrzEkqqykomCYVoEu49WSZyJg5yNAuoo1PHWghfws8Y09QnUXIHC3Ti/eyaeDO7xN53n1Ei01/7N+sHAtNsk1uPjUrmAMxQGi1V5ev9ZdLYmh8WKzMQu2/Y6jL2Vnhcli/YCtx3JKEq5hXJ9/CGkCXoS9s1DD9LWfHFwf3xk5ZeL0ImSYNc9movneWAnADoX9pnDjM7AUQv9rpt0q4rzS7D4PqzdArx4J+P4PjEasGc+LUpS4hIEpeGVpoceQCMcsuTZAeKMTabQqTiCNvQRBGVSfhUVBVQVSXg2c201YoXzv5GNReFIPprMvaw3NCF3mmE2mzhjyLPXHCWI132DKdJ/dhNTh0cLUTN4B1RuxLs5mZAUwTKZzoZ+vvQUcR/0jlzxAuO66rEuYDfiO8IaTax6sugcTvHTbfG8kb48JIcMTmLZ8x3/YC+67k7WdJMtQZrO658A20L1EYLCOHVm9M5sRRJropHS8nmr6Rvs2rHYtX5o35RxYZkc3Cwn4OxNG+PAQ52n54LvZTeeOhJ6DA+h6bEkUUJdK5yG7NXdBdQMOZA3h2skyyIKciZqfbnfMUwFnbCH/AE8e3+7Lq0QUBsbKyf4yhXJO2GLCrJrUwdB7yBNRMWj1BYpe3n5pGk87xep3d7gdZiIn1nJNO7bWQel6jx49/6tgKAxkTQmJmWQjXyg/GUYmEEXV91uto3ZeLw== X-Forefront-Antispam-Report: CIP:34.202.228.63; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:dg1.bose.com; PTR:ec2-34-202-228-63.compute-1.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(54906003)(2906002)(6916009)(36736006)(86362001)(316002)(9686003)(81166007)(6512007)(6486002)(8676002)(70206006)(47076005)(8936002)(26005)(53546011)(5660300002)(52536014)(107886003)(356005)(336012)(4326008)(186003)(82310400005)(40460700003)(118246002)(508600001)(33656002)(956004)(83380400001)(36860700001)(70586007)(116584003); DIR:OUT; SFP:1101; X-OriginatorOrg: bose.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 03:09:43.6217 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 777a1a57-1494-4454-8c5b-08da27323639 X-MS-Exchange-CrossTenant-Id: 5d8ae07e-7fd0-404d-85c1-453ff3dc8c1e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d8ae07e-7fd0-404d-85c1-453ff3dc8c1e; Ip=[34.202.228.63]; Helo=[dg1.bose.com] X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT037.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR08MB7912 X-Proofpoint-GUID: cWPco1usbwOapxtR-YUG5Uy71fsCBIsy X-Proofpoint-ORIG-GUID: cWPco1usbwOapxtR-YUG5Uy71fsCBIsy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-26_01,2022-04-25_03,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 mlxlogscore=654 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204260019 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/mov.c : Avoid seek request with invalid seek offset ( 9223372036854775799 ) after EOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Banerjee, Debasmit" , "Patel, Pratik" , "White, Brian" , "Van Iderstine, David" Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello ffmpeg Dev team, Could you please help me to review this patch? Janpriya. From: Malviya, Janpriya Sent: 22 April 2022 02:07 PM To: ffmpeg-devel@ffmpeg.org Cc: Banerjee, Debasmit; Patel, Pratik; Van Iderstine, David Subject: [FFmpeg-devel] [PATCH] libavformat/mov.c : Avoid seek request with= invalid seek offset ( 9223372036854775799 ) after EOS Hello ffmpeg Dev team, While integrating FFmpeg for M4A , MP4 stream & facing issue that mov demux= er trying to request seek for invalid seek offset. Issue details:- - Modified doc/examples/demuxing_decoding.c example to support Cust= om IO call-back because we have our own mechanism to read data from source - In custom IO seek call back , we do not support =93whence=94 val= ues AVSEEK_SIZE & SEEK_END , used to find stream size ( returning -1 in bot= h the cases ). - In attached screen shot , where we are observing seek with invali= d seek offset and the seek requested after End of stream is detected - Seek offset value 9223372036854775799 always the same ( I think I= NT64_MAX =96 8 , 8 is length Atom type & size field ) - If we allow to return proper stream size in seek callback then th= is problem is not observed. Fix : In attached patch to verify EOS condition before going to parse atom data. Signed-off-by: Janpriya Malviya --- libavformat/mov.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6c847de..9704550 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7556,6 +7556,10 @@ static int mov_read_default(MOVContext *c, AVIOConte= xt *pb, MOVAtom atom) if (atom.size >=3D 8) { a.size =3D avio_rb32(pb); a.type =3D avio_rl32(pb); + + if(avio_feof(pb)) + continue; + if (((a.type =3D=3D MKTAG('f','r','e','e') && c->moov_retry) || a.type =3D=3D MKTAG('h','o','o','v')) && a.size >=3D 8 && -- 2.7.4 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".