Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas Gaullier <nicolas.gaullier@cji.paris>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] lavf/mpegenc: fix termination following a fifo overrun
Date: Fri, 25 Mar 2022 20:59:38 +0000
Message-ID: <MRZP264MB24924030EE0FDAC72E4574B69B1A9@MRZP264MB2492.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <MR1P264MB248376D90554D07BCEB5B2DB9B179@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM>

>>Could this infinite loop also happen before switching to the new API?
>>Does it happen because avail_data is zero for all streams?
>>
>>- Andreas
>
>I will take time to double-check this very carefully, but in my experience, if I remember correctly, it is nothing easy and was already buggy before.
>(but with the older API, it was almost impossible to reach such conditions).

Well, I really don't know how I missed that but indeed, no avail_data...
So, I am doing some testing and post right afterwards an updated patch with an 'has_avail_data' check.
The problem happen before the new API, for a long time ago (I checked about one year ago).
Thanks to you!

Nicolas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-03-25 20:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 16:39 [FFmpeg-devel] [PATCH v3 1/2] lavf/mpegenc: fix ever-growing fifo size since the new API Nicolas Gaullier
2022-03-22 16:39 ` [FFmpeg-devel] [PATCH v3 2/2] lavf/mpegenc: fix termination following a fifo overrun Nicolas Gaullier
2022-03-22 17:05   ` Andreas Rheinhardt
2022-03-22 17:29     ` Nicolas Gaullier
2022-03-25 20:59       ` Nicolas Gaullier [this message]
2022-03-22 16:55 ` [FFmpeg-devel] [PATCH v3 1/2] lavf/mpegenc: fix ever-growing fifo size since the new API Andreas Rheinhardt
2022-03-22 17:26   ` Nicolas Gaullier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MRZP264MB24924030EE0FDAC72E4574B69B1A9@MRZP264MB2492.FRAP264.PROD.OUTLOOK.COM \
    --to=nicolas.gaullier@cji.paris \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git