From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1A375498D7 for ; Mon, 22 Apr 2024 12:32:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 015BF68D29A; Mon, 22 Apr 2024 15:32:24 +0300 (EEST) Received: from PAUP264CU001.outbound.protection.outlook.com (mail-francecentralazon11021011.outbound.protection.outlook.com [52.101.167.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C6DD68C8CD for ; Mon, 22 Apr 2024 15:32:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeWG2KucC9abQkkTE9cj1Nzjkg0geQynILoYQ7rUotKE3wmh7pkwEoulLewdLEMxjIzGIRIah432d0Sktrypj62w6/aiHXlWKuYFZQ+rT+bm4SM8mapZTDwTeJk990LLdSYpQSunayOVT3Gow2PYvdWpj1LsDJYgWdRrmWNhYnfFzsSxzCVK4Z1zOuByMzVORgPkWO30HoOR8tMCMpq1+QkfTIs+NyudM7R+9L4XBediCbN7S1d06B7MYFcx5vkPIwNVtn+G1fT2+CPgjIHXokZBMMhj3VaCWpfMgqyeIW1rhtyD6rfojYDZpbjM+NiB1qnOBSGvPcoqsHXBXIwhdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hcm8IA+GXDjYeko4haqUd5nA0anmoRY1X5Z3nfD1hPw=; b=B441IJhysYNafA+FGr9tAo9EMMjuRH9pZ1oilwxgEtb6EIgRm2FR7M34ugPuyLH8bEnPrQj/cTf05t34RNaEHUZwPlEYYFOeNc0ateaA6H3EkzdiNeR/U/QUwzia9ds3TmM9C2tDw2mZ1UO8znjScThU0p68ubyS5G7jG9sw2fxigOu4TmNLWUV3Ej2KS7oeD2ufoi9AnoEW7a4F1oEsURlAl/KSUYeNOEx7xspciDC24eU0uYmY37V4r5QrsuuIm+3RoekrHT1AzYUvqjpLKEaMOAkJfNUuVLTBwN9O23TCPEf63fsfJjFHLWWZEqhDc0YPvQx1DO402lPX/R9rhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hcm8IA+GXDjYeko4haqUd5nA0anmoRY1X5Z3nfD1hPw=; b=G6IrJywvaQFQsVTtZ1MmjcBkhT+3h/UGWu1WNrdWwE1l24wUJoZefohNKmTYMj9N24P6R/Dbj0AvBg10vnGqsbCPxo35CCpXM97wPZjlXEIf09mty6GaSZ16j43HCyZcRzeJLbrniiL21cpeKh+5vZyuQRPEi/7kqHX8UR5TeFbWc111D3AFgyzjMBf/K09iFpil89/Us6XSQJseZ0DtP59cTHz5WVuYEodkRwmO4kfs8XmUUwPDTa35fkgBsQ7We0TQhYK/o+WDP9z/mR8m7sQ/oA94sfr9QPexaYbw7xdI3mwGzYYDBiFoyevckS2CeEWycImrvapdMl8PGHSooQ== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by PASP264MB4803.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:431::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Mon, 22 Apr 2024 12:32:14 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::74a1:99ad:46ef:4441]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::74a1:99ad:46ef:4441%2]) with mapi id 15.20.7472.044; Mon, 22 Apr 2024 12:32:13 +0000 From: Nicolas Gaullier To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH v3 0/1] avformat/demux: fix accurate probing of durations in mpegts/ps Thread-Index: AQHahURjfPGGs3SnfUWz0HlPCi6ol7F0VsUA Date: Mon, 22 Apr 2024 12:32:13 +0000 Message-ID: References: <20240402212609.572420-1-nicolas.gaullier@cji.paris> In-Reply-To: <20240402212609.572420-1-nicolas.gaullier@cji.paris> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|PASP264MB4803:EE_ x-ms-office365-filtering-correlation-id: 57a07508-4b5c-4b10-0f80-08dc62c83d29 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?iso-8859-1?Q?NKgIl2NMrQpIL2lhFi2X8QC4i8jbqTcqfpUAOfuDECTpiMMt9TCXjX5uo+?= =?iso-8859-1?Q?EXJH6aR9FvO8/RmO8qu0ZPzjWdz0kv89EM/pbCZOfMKU4Kxej5z6Hm2LAT?= =?iso-8859-1?Q?KnlTirXdjJjO7lpbacjosHb4fn/dOa2FyUDGPhC8YfHuZk0k9gxpx7LCju?= =?iso-8859-1?Q?gcIaUNBYY6UYkPoWg8/5rT0rxvEDCWqYyY+YbcesGKiXRkoiPmXSyScHoq?= =?iso-8859-1?Q?tBkv2teMNvxIEcXxrH0fLsPMBlKQft0aWx0E49a7bNicPuw/vTn44pGqCC?= =?iso-8859-1?Q?AoHkFy12VsC8tCx8wYDwxv8+JF0xwxobtwXBm30beB1sqyE4ImWMF+tnES?= =?iso-8859-1?Q?KZeB5gA/coN7cthog1WtAUH2npHabBcRiBZOH2EnKjqCZktbzjU7WrYhv+?= =?iso-8859-1?Q?boICFhGfstjJIsKA7oGYnZaV+gMvv3Cv3vyn/bZwX5x8nvio0aZaJsoVAA?= =?iso-8859-1?Q?d02Xu2vA3nUu3KiVtjPzwYiWw+4ydNL72NAFknGpxpd33fq3gEJNjLP6sz?= =?iso-8859-1?Q?qDIoiMf1ZGNLXUCkRnTwoJEEkU3OjrBhYFvRToqtqsvqSN8FqeZ/WoJJsM?= =?iso-8859-1?Q?QUdWz66XVAFhMY6fIwJUKx9mKcNNcBx5l9+Rr+Qz+TqGRuMYArGl0bNBKU?= =?iso-8859-1?Q?V0AK+mHyH6Q8Wf6oc2dr1KJRG0AxNwMMcLhdy65y5uJ+7z2VgwNtM4gqnS?= =?iso-8859-1?Q?MqseRrdDU+Jlp/kxqTOfhWMadSPX2sRV/KT+2pfL9sKuUkbIbiqoaPHRtY?= =?iso-8859-1?Q?j0ytL4NBFV+N8xnd8wJqoVgg/8riAiumw015IlDripA+93taVsx9tAdylr?= =?iso-8859-1?Q?9Fyy3aMc6Rp0Apwygl+S4r5VdXmQrpuaCVkQXX2M34n63ndx6sQCdJvyk8?= =?iso-8859-1?Q?UszQ1Jq9Z92ATEB9FnKf519IwGfCtLBD1/tO5BLOGjzLWQbB0Hw9Eusf3Q?= =?iso-8859-1?Q?F8TaNMRXLltvjszvSiErnmWm92GP7NJQIGmf2hhXag/QZJJzmOgUFSGV2F?= =?iso-8859-1?Q?ZsTXyHgvPYlH01SfcwviRmV+VXVXOon6JR/OaRQJ9oocvIp16xD3WEk178?= =?iso-8859-1?Q?M6Pb7+uec7kLOf+y+MrtijQHKtemdT6B/Vkwn3+r89CIpExt4dQ+trChuD?= =?iso-8859-1?Q?yYsoMy2pQB5ZxFqMylaXUwCu6waGOW8oTLfFQWA3i5JJVkN6X9TzxK4wHh?= =?iso-8859-1?Q?T4XqQynxj9IFtfkL3g8yL0hPnOMsknB9DwpNEMu11nFTHiAhOm0X5oe2/w?= =?iso-8859-1?Q?P6jmeFGWreFl8VcHxg2lFDASxGnNTXscV9uTc8gTt79zNHJc0RRGPJmbm6?= =?iso-8859-1?Q?S5yTobGJ/fki6gRb2bdRH3pofg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?0lZjtGK9uYPKswu0an4Ck8Svz/WhWgjIrbGgMn8EQEIrmLB0tDA4i4Ou9U?= =?iso-8859-1?Q?fp/YpLQRCPSGeLMx3BidKmbqnmGCndgQBaU55lVNaYc/mdzLgtx7fdVE4b?= =?iso-8859-1?Q?BGmny+WafmOPsStmAQZqg65+fvO4sxG0tM0EVDNcvmBrxsBokwCICuXiXd?= =?iso-8859-1?Q?R8TDAcVtvZA9L68FsLtJocfK5uPlDJBT8/p45Js7+qtLWvAN2fnFIULWM0?= =?iso-8859-1?Q?StNzKVZOglYgvBOJGMKVTsfrlX2phTXu0hlI7fJl6XOadjHIFBOHibYjdC?= =?iso-8859-1?Q?/xJJfv1uv7431v3JhR49DNQn852jK8dYH3zC5SQ/yIllTW2jBhmneYDgiD?= =?iso-8859-1?Q?bKXgtTTz/fltN9nfJXkgd8DTXDRCct2rB9B0cxuQzkccP76p3Bvz79Xota?= =?iso-8859-1?Q?5Rt3/SamBlS5vHtuziX4BC3321Dgge4w94/RlHmOHu3vja+kjWOH9+xMuD?= =?iso-8859-1?Q?b4W2L7JSAbP8cur0DZrQj0eScPilPZM26awXVzp/0OcuMQ1700DfWBlLIM?= =?iso-8859-1?Q?QaAm4pybDzhNYjBLCeSyvHeJ+R4QRKiVWqOxigDYyBfj4q/uSyT0gOSLvu?= =?iso-8859-1?Q?l/0fW+FHrnu89+VvIOT86A0/2reZ3FvV//yZiF1g7CI6TZK36LhU/Yp19j?= =?iso-8859-1?Q?GfESZRIFhnp21YTwEj6ZZcIZzH/vm6z+xHPx5vpT7ojHeTuapuJNs64hn8?= =?iso-8859-1?Q?6iC+S9mdYtf/smKeDB8HeYoikbnDL7PmCFtTYYQ1smd/bYdHpETlcOMVUL?= =?iso-8859-1?Q?/n7UygrDcWSWFAcow2qXrP45XDotlv/g1aClZ+mn3JMq+v+UEsCJ+ooWtq?= =?iso-8859-1?Q?fRMXa/uEtoaSI+fnFR1aGJ6fTwrNyd08hQbDtaM6VGagNNnBVP4Yvvcok+?= =?iso-8859-1?Q?iLeXuFtzztBUMPPsCLMy+7wsfa86H68leGkx4zd4BktKB2KJ7vivnnoMgC?= =?iso-8859-1?Q?WSH/czdDo/ZpXd5x7BW11ShTXdWabl+ttpNYMi6YvWPVVGl3eVj8Edu8Ss?= =?iso-8859-1?Q?UV4Ni7sR+fSpKsbYsi1liKCtj/g6hzImAzsaGXSytZ4uDcXcGDPh2V/mi3?= =?iso-8859-1?Q?1GGbEbZurXno15uoEhanrRKf9btW0PD+FTNN7s5436kjXpIvcYd9sYnzNO?= =?iso-8859-1?Q?brUcXEXpXIw0UxEt9tzcuxcyNgFLJBmmmdS9dV0wo7d+VMuoFp/jVObBYQ?= =?iso-8859-1?Q?2bK+CaWCO+naSjSV3juuLtZIhLUL5KOM6h2noty5svt54mVzfgOxV237pT?= =?iso-8859-1?Q?ZmVHxt41yvFPuOGvH38FCtLdEAfxyA28B5UB2cyjSE0QOQbmDZSOAhG+gv?= =?iso-8859-1?Q?sTz51RRLiTpgz4NWXTbHUFvj7REsV7/i3XS3CKXurAH2TeRdmOMk9ENY7r?= =?iso-8859-1?Q?InEfqhr8lTsF0nGlsk4WZ7Eb314uQaYZ2bXpXvym2Hcq054Khcz+ggpVj2?= =?iso-8859-1?Q?w8C6mPCV/gvnZAtEFJvNwDlIaNkrAwKxbBOY7TWgUDjYhkCPCwwTxrWXvt?= =?iso-8859-1?Q?fZ1fty1t6WhIBoqQ3LfTi2TC0imdeFuJkfS6fGW6+YVjpixjBSMMHw18I4?= =?iso-8859-1?Q?kZLyW94VoIEPe7ouatuPWErSKyNcmE0ZnrXNaUu3u0uqgL6urfg3Zc8EWM?= =?iso-8859-1?Q?KG3o+XPwOFMLpwTYzj0cGj/v8Uiln/cV5f?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 57a07508-4b5c-4b10-0f80-08dc62c83d29 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2024 12:32:13.8764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O0K1oPo0ft0ZMmmn6tGu4QjXX/ftKNre3NtGiVuvvDRTxkOd4y2Qth7h+Vqqe4wNqaXTZsc5LoBbFVsE6yFUORyHpmSElKb/R0N61kes6vk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PASP264MB4803 Subject: Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate probing of durations in mpegts/ps X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >De=A0: Nicolas Gaullier = >Envoy=E9=A0: mardi 2 avril 2024 23:26 >Objet=A0: [PATCH v3 0/1] avformat/demux: fix accurate probing of durations= in mpegts/ps > >v3: rebased after ed9363052f4b8b8 applied tonight (add duration_probesize = AVOption) > >Note: I have no other plan for demux/probing; with these two patches, I ca= n cover my use cases, especially mpegts-concats. > >For remembering, previous cover-letters: > >v1-------------------- >ff_read_packet() is more lightweight, but it leads to important issues whe= n looking for accurate durations. >As a side effect, the code looks also simpler with regular av_read_frame()= calls. >1)Updates in the fate tests do exhibit most of the results. > >2)See also more directly the case of an audio PES containing many frames: >>ffprobe tests/data/lavf/lavf.ts -select_streams a -show_entries = >>stream=3Dduration -of flat >Before patch: > streams.stream.0.duration=3D"0.757556" >After patch: > streams.stream.0.duration=3D"1.018778" > >3)Here is an additional (commonplace) sample to demonstrate the benefit fo= r twofields-encoded video: >>https://0x0.st/HFbm.ts (say h264-50i_mp2.ts) > >>ffprobe h264-50i_mp2.ts -show_entries stream=3Dduration -of flat >Before patch: > streams.stream.0.duration=3D"2.060000" > streams.stream.1.duration=3D"1.176000" >After patch: > streams.stream.0.duration=3D"2.080000" > streams.stream.1.duration=3D"1.200000" > > >v2-------------------- >v1: There was an issue with teletext where resolution is set just once at = decoder init (teletext resolution is fixed/hard coded), so it is somewhat f= ragile: when a demuxer context update occurs, it is lost/overriden by >avco= dec_parameters_to_context(sti->avctx, st->codecpar) in read_frame_internal. >They could have been other scenario besides teletext, I don't know. >v2: So now at estimate_timings_from_pts, with one or more seeking involved= (seeking is detected by the mpegts demuxer and set last_vn=3D-1, so pmt is= forced/updated and results in demuxer context update), it is required to >= preserve the info in codecpar at first. >Thanks to Michael for reporting the issue. > > >Nicolas Gaullier (1): > avformat/demux: Fix accurate probing of durations in mpegts/ps > > libavformat/demux.c | 36 ++-- > tests/ref/fate/concat-demuxer-simple2-lavf-ts | 170 +++++++++--------- > tests/ref/fate/ts-opus-demux | 4 +- > 3 files changed, 100 insertions(+), 110 deletions(-) Ping for review ? The patch (https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3D11386= ) still applies on current master. Thanks. Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".