From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1F43848CB0 for ; Fri, 23 Feb 2024 12:52:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F165768C5C8; Fri, 23 Feb 2024 14:52:41 +0200 (EET) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01on2103.outbound.protection.outlook.com [40.107.9.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5DC6B68C462 for ; Fri, 23 Feb 2024 14:52:35 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FclymTOsN/7MyHjZwDeXMCAmGDWAF095M+hmZoKpIyPOutjbNfQTlu3GsTyUHlZY+q3yqRfFcxAvKrAwuvt6XURgAn4XdzamzQ2fCKcPEo8JtxnukitXtuHYBc9UEmamXZZkvyHts3tTwM/MqmuiN+rUxx5P/YKlZNhj745pUlBLmprnQ0tshw4MoOk7ZW9WL8jruHyGV1we2OdE7cdHZm5l5300/kDXoAocrr2xXxj2FSHcJku1zXUUP0mtuog8p9IGnxT99VbF9mPQvYYqDdr8zA2elbe+1zo2wGQ7CTXiCeD7N1KT3TTA5W5YkSho7rZhqp1lsPAp5DJG1+CTgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q86u/2Lx3H15Z3INvWn1tk8dEBF9tKsgzos3YusxeX8=; b=CxhNOf9h0ymJcYVJwYMwM15XFH3cPv8U6V6tDfE9GTKvIiENpQgf98lsXZaiW/jfFBc3dMaAk3AU6n6oHU6o1qZNwyQJ0jafRUwKZRWvBR2hXahNum3cX+ZYSRw5MN/exQ0eTsaf5RfPkGrxLFIJsgW/WDNiVPoQD04dbJ0m/YE9nHVTfOlyvDqw9xQG0z10ob/wwFV5NArF4J8Ksayri5i+5+jdSFFRvtSJuPDKSpQhSwXfLG9GXZrv1qMNy6cdJWBVtgCoWb1WYqzp6NhVzRuiLEbQFTqoXxEAmzxsM82KfO+gC/ZNPwih/m6pClWPCP8ajINwaFQU341yCrUikA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q86u/2Lx3H15Z3INvWn1tk8dEBF9tKsgzos3YusxeX8=; b=AJo2rBl2jLaRFI/2kx2D75K9U2V9kILFOjlNbPur5wUapWaZnL1qjIqZCrfkctEZqPvbvsw2ybhpmBhax8bVkXIcL/T4W5cS1CPHz4V92u2k/siKix5EffYWr+GS8as4Y4zmaIQ2dFxKZQ2Rw1EdEVZv8P4m5qGUcbTPeLEGt5+2QIwSa3Pv8ilJi55UWHzjmA0NW4YtzKxR7DDwX4duutyj+ndU1W021/JyGsGQ7LmvqUNm14GLwZ+ImZi7YpBGhUbN3cZpXqeJ91G8pF+FkCF72mYLZ3qpfmtOalZvtGX4U6fkmfU+13pzUDO4/YZQB998XCEft5MTQj4dw8Vorw== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by MR1P264MB3586.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:26::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Fri, 23 Feb 2024 12:52:32 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::d61d:adb2:c9b:ff7a]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::d61d:adb2:c9b:ff7a%4]) with mapi id 15.20.7316.023; Fri, 23 Feb 2024 12:52:32 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] avcodec/parser: fix fetch_timestamp in a scenario with unaligned packets Thread-Index: AQHaZBp89HKQQCv40EClbL8VRqRnm7EUNaOAgAOlmEA= Date: Fri, 23 Feb 2024 12:52:32 +0000 Message-ID: References: <20240220163302.1943993-1-nicolas.gaullier@cji.paris> <20240220163302.1943993-2-nicolas.gaullier@cji.paris> <20240221043205.GY6420@pb2> In-Reply-To: <20240221043205.GY6420@pb2> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|MR1P264MB3586:EE_ x-ms-office365-filtering-correlation-id: 3c4829ff-1a25-4235-20e0-08dc346e4ce4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3z8mEOWeHDkWY706k6qP7OpjM2+Yiux1Z6HMo6ZNYDvEzzhqWmWCfkFNIahE8zW2ZQ56bdf+6zwo1safh0UN0IFIfGsrHs51T+BeWuDBsW/6Lrha1/9a72NW5DvvMCDvqzjDqv+CftSjolV3fzDzzREVEP2+Y5NsEd2qkDZ1GLql+urg+lxWzeK/maHCbFBqsLRrW0gFRBTZYbNVO0OA9QyA2xjLBGZ3RbayC+nlPh6hIh3gc7Ix5wqtcExEFbRaM3HHDvQxPPyvTwYXSTe5heIY8LrQgKwRMyZhfFQJOeee3zC6usP5MWmrBX2m49I/tjn3TI9n6MKjSjtHLYUVnnmKR7v7iTl62J/y0CUoHgIGhiSQXmbbh3TqWnbKX9X9TKp4Akzh0yxdXOVagGF39JeFa1v2C36pSsIfCnSyFM2P7Wx/o1fOFQFmqhSesONQ78GvhLJWO6dgDWVzaIJTNRi+KMzA/MrLvB0Q3ubNOeF+/mUaKmAacfX5N32KPjGMslAhXIJu9tNSUJIuLuMMTPoabyfzRcw3g1wagixm1l9g2EEEapY7+jnPw2f1UhzXJ3JkZryzx6M+oC6Z4V4eF4xjGXn0CIjk9BqqlGCzRts= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZTJEu069fn4PbmQh59NqE/Zjzhi6x0Zx8yr5kjwLFHJI6w6nkgxh5kBvZU?= =?iso-8859-1?Q?NF2JB0YLWXyryAatHK1Yfx+c3cZKJAgUM6OBl3MTz2hpRAYkYX/rpMPFtg?= =?iso-8859-1?Q?kcEjMjB6VKNlnj4b4v31i3XQdW7HOLGLj31Hdnq2ThYrTlK3kF0YHlI8Vn?= =?iso-8859-1?Q?HI9jIR41Sc19tkog1Dmv5+0V/O4HgD8spe5TivcG70bBPecChkzW+jFQLY?= =?iso-8859-1?Q?1L2LCzPqlSmrfvL/MBXuBZK09CGUY87datQdpQ050KfSOrs75p0oDlmRm4?= =?iso-8859-1?Q?+DjMSvXbpzM+phyxBvN7SLqngsoAcI0QalamCADAeQ2mdqET1U7vOzLvYN?= =?iso-8859-1?Q?AUYFry19ieZ2tSt6EwFPQIvm3eC7egGpI2Nwohwz7ctAm9Lr+mxm1lbI31?= =?iso-8859-1?Q?U0B3e2ihZ1O7idG6pmR2qrsQaxMJ6Np32hloPSmtLZ1a51HP03Zc75HMcN?= =?iso-8859-1?Q?gfVSFA6R6ZeLds2RSnbTzDJrvOfUm0009b/3BsB5/K7MQUVlx2sn/SRC+h?= =?iso-8859-1?Q?X9epAOzeV3ucNzBSRJSTfQWV5nk/BvKGz8cr1v2ZhF7ZKTp6YKAEUvRMpQ?= =?iso-8859-1?Q?GcDaYpfB/l0NYd4TVdJ0WFD7saQeCxO2/F3vdLhw6yqYkmXegkXepOqt3w?= =?iso-8859-1?Q?G8/6zTzTIcNZBvWKyoQjSu2jSuMj7jnVO4YCQPxVBRk+KWb4vgTct0SKed?= =?iso-8859-1?Q?PKZlDtnmrnwIK8nVLS9a7dQRhskDjAJWG6hIXKoLG9qjUjb6hL8ef8YbrZ?= =?iso-8859-1?Q?JYYiQik2gt6WfuIgV8LF0ShWP7OYCdD89mrrp0Yend+TGgDOCkEojbr7iV?= =?iso-8859-1?Q?JJD3kW/JOhYkNFxTNZsgasaoAhG9qMO/ufEods1BmU+sY+aKicjm9aZb4O?= =?iso-8859-1?Q?KQ4hnSXmq8TZCfEB9K4T7lOAW5G2G4JnUP8/eVs37iD24uxYk1JHTxyqqb?= =?iso-8859-1?Q?XSf91siJi6IxkNQ5qWixascSmE3wOb8ow3lO5ug0ZeyCVe4QRxlFXzzKiQ?= =?iso-8859-1?Q?fsuO+kDRDbk89vYfpGRXCFmx6+TH6Kr4PZg0A4DGgAjImNuop45yJV8DAx?= =?iso-8859-1?Q?Dx94QUzScvDJYfyBaKwAlcvviBbUa0+8m4pxwCyBYx1dSq1ZLBldz8u8IL?= =?iso-8859-1?Q?6HtSyrCYBzIQlkuGRx5Nd3loJrotloQeqrHyq6yo60jtq05WbJhWHxkrqv?= =?iso-8859-1?Q?VCr6/mNzHLWRTUd1zXb/bm2P7ihHB/WQ1+qoTGcdcfk1UZVpRbSc/hmmQt?= =?iso-8859-1?Q?YMqd3eweA7PLFzhAfa6i79f+v5mW2OLZgeu8QJgVcVn2THTesbB4wyDEid?= =?iso-8859-1?Q?CZ/fjBzeektyDBBQbVN1tCoxHAa6EZFHsGw9Uoyb8ZwE6QAok/5BLlR+fq?= =?iso-8859-1?Q?it4YXHNEtojgLkm0b1w0LOnxrB2Fkjz2TxC3LCGHM/Bwkq9OkBO32/27u4?= =?iso-8859-1?Q?nm91AoWSq60ENs4wL7kKv7419nL+F4ZpZdgUEV0uk6b75J0yrrGWm7YdGw?= =?iso-8859-1?Q?lAPS6JnfQsE2ENeJNJZo0702CEIlLKWW7X0WCmcaZtMzOnHc9eG2O+Un/6?= =?iso-8859-1?Q?AdBK4ci5bmVl+0n6p7/dW+dUnB7huO5uy6EQAYeXmBr76vBWH790NO6A4t?= =?iso-8859-1?Q?grv3NtqO8qCuAyXz4i0BGLHHk5A86JN8im?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4829ff-1a25-4235-20e0-08dc346e4ce4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 12:52:32.0780 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g7dQD5Fb46uTwD8lUozE/A7hWejaD9b8SlhCM4jUGgsbVbDlE9adCwg81QzLJloAjj5kWFEPgIbbmbA5xC9fqT41a3zlvCDaxFfnB8B9NDs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB3586 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/parser: fix fetch_timestamp in a scenario with unaligned packets X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >De=A0: ffmpeg-devel De la part de Michae= l Niedermayer >Envoy=E9=A0: mercredi 21 f=E9vrier 2024 05:32 >On Tue, Feb 20, 2024 at 05:33:01PM +0100, Nicolas Gaullier wrote: >> Fix fetch_timestamp when the frame start is in a previous packet. >> = >> Signed-off-by: Nicolas Gaullier >> --- >> libavcodec/parser.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > >This change looses pts I missed it : some broken streams are missing the zero_byte which makes the= current h264 parser code to borrow a terminating null byte in the previous= frame if available. It seems there is currently no issue with that behaviour, but with my patch= fixing the fetch_timestamp mechanism, it becomes one. So, what is somewhat tricky is to guess if we are facing a broken stream or= a conformant stream which actually has its zero_byte in the previous frame. In my experience (including the sample from Michael and a sample of mine wh= ere there is no available null byte at the end of the frame), the "usual broken streams" are missing the zero_byte for the first NAL unit= which is an AUD, but the following NAL still has this zero_byte. The following patch is a proposal to detect and overcome such a situation: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3D10877 At the end, this patch is required to handle broken streams and thus prepar= e the ground for the fetch_timestamp patch. Another option would be for example to handle the data_alignment_indicator = in the mpegts demuxer to force the alignment (ex: with a parser state reset= ), but it seems it would involve some big unhappy changes in the code, with de= mux and parser tied together. Moreover, I don't think it is reliable and th= ere might exists broken stream with unaligned packets that we would still like to support. Any inputs concerning broken streams for other codecs is welcome. For examp= le, it may be required to handle broken hevc streams alike h264 ones: I hav= e no opinion/ samples for that matter. Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".