From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6FF7B4457D for ; Fri, 16 Sep 2022 08:28:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4BFB268BBA5; Fri, 16 Sep 2022 11:28:54 +0300 (EEST) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-eopbgr120051.outbound.protection.outlook.com [40.107.12.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C6A7A68B9D7 for ; Fri, 16 Sep 2022 11:28:47 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jKYWT+1FGPEeGTsg6faXl0im6cw5M0fSJG4iFFXaISgUt1urF7lYL+Z9mzfFr93C4VWBEwYIHDl2/BBm9UKxiQwALablCwnTfK0vK2kESs+28yGi6nQa1Kl0HRmZ/tQH+vjmhINrivZlKCCBNulace27/mDew2MsVIFjnors7goAKEOrmbOLuZ/S4WdCHxCJOaNcbqjVUxuRFHtIW6k15IM62VQXVAySPZQHWdL3bue5EOQHXX7l/cTItLYrxrVcKmT9+SQaUQDsVfPTVCsVZglD72bX48Uk7/zds52ARgywwXDIty68pbupQcWm26Ygbz3f4gVUK//kkZ79a6/1NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oomJZRAfdwLra4TMYvA3QGtklz0llYW28vRFtVX+NZ4=; b=cNdXvjSUpK9XCb/QduOWg6rQUsCkYvyZYW3oTM0Rwt5F2TyGeyuN3iM+AlGQE6ecTVJ7IhLjiMLsdkIVhmKMSDTP1+E44ubMN56iwuGk4qi8SgxD6CWONqUKQSPQUO5xu4EN2kLQp7JoBqcbzI9s/bs1+SeAXHRfE7SzeYJOqYC5E57p6wL+z7HftTWcHCPA9pCNj0UvCFtLOlctvSdC7nu+2VGwi333i/Ifx85rWzrPFe0CeYGmrascIQDknXHpVT/RHaJ+qUd/MfhOx4qrcgFxtkilzZ4UJp2HeYrXkv83VPizkmpOhEbFhB/qc40Sq1q5M3BwSwwPX3xNMxyARQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oomJZRAfdwLra4TMYvA3QGtklz0llYW28vRFtVX+NZ4=; b=G05fHxP7iUMRmC909HK8AgkHLYSQ4G9nnBnFVSY6N2y7HxLT5ERudvO+QYX9Ujxu8uMWxZ4iFkZn3HFEpH3HkuM5JjyYnhBFm4KrIrTZNrx+8ThcwxY9nFtL/xUY7+IaybaGMQkzYmYGx/WT7DevoSwVljX9lvXroJiVjAR6EpXmqhOKPC5NLlmyfwvKOWWUuVR0nte3T69tieBvIOMX9I3oJeGwNuBLxMEDrjXfzr+p4wnU8Atj4ZBcHNzKTUiGNaQU993IPU3IcxQECZphdgT60EFG6Mm3bL1T/++T6j4twCUkIA+0sbeId984K3gvCm3wktJfCMd6rD9rRyQHBA== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by MR1P264MB2882.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:37::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Fri, 16 Sep 2022 08:28:44 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::81bb:3d5e:b14d:ca95]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::81bb:3d5e:b14d:ca95%3]) with mapi id 15.20.5632.016; Fri, 16 Sep 2022 08:28:44 +0000 From: Nicolas Gaullier To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits Thread-Index: AQHYx7gxhpSvR1tSEUCcDrULm0Od4K3huekA Date: Fri, 16 Sep 2022 08:28:44 +0000 Message-ID: References: <20220913213127.1756-1-nicolas.gaullier@cji.paris> In-Reply-To: <20220913213127.1756-1-nicolas.gaullier@cji.paris> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|MR1P264MB2882:EE_ x-ms-office365-filtering-correlation-id: f504659f-4441-48e0-ae0b-08da97bd782a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WGgvRGdgUVUo/vVrvH1MymOG6vHXlzCPnc/1k6JWsB4VCc8t2WLWy+BwchxS9L7yzYl1zXZCVgILrInKcBFPmcbqflZoNSP5fyB6W/Ue6pwmyU5ZvNHU4nNhc2no6/9SJc8ekSsKurczG8UmBSGbwMVcQKNYtsFdYeZJJphAlgIjSkKzs+a6YOSk8+aTZ9wtQ8TSMnLkG/ItZBkKXHG79KCRyBK/iqHnSeluFynhKSjq4ei4fjHUNxRgztd4pbpamaDV10MYMNUMrjF5T+oHxcPziEoaszkqizQ0S+tq374zhGGdcjST+KrOzb9Yrik3CS113OPliSbUJfoekhhADgICMs82Eqce9RZtil8/dWtJFeT+9P45Z9MCIC7BOT6y+6xY2idLexolEdyiyBTcImzNZi9PPBWA4TQjUCwAnrCXEBjBwHZbcy8a4nONp9k+9JX6NCN0GC/I6ZFBgCZjCkRi089Q0C/vUwvw43oEmKcBJuHRUkCfg8toalWt+/Y4YD2y6+eCZY36P8TII5Nzg8qpRsnLYpd4jzDAxJtPMAcIYqZKRAcGwJzPzfu/3Cud+wfivOn4aiQMrN5jcqRofq88Xw3zOjio6RvxBQlvOgRjVGmnyyukA8cCVdzzopezwO10v00cIwbhZMa/wUI8i4XAhQ2Y2g3ddfgVD4RK1sAP2XSnVRZtE08CL1+CcA4Fmjq8vi7n+mksau2zVHB2DjmEqZhIarWu1UtCwt4jKzQgx/XmXcas3ek4iDMLMptWjzex7nnHMjactc7JzB8G99GMww06ZPaTQ5RvX8m0AKJg00eAZSArGHsEJatA2T3dnvufAHwL1Ut7ErUSh+WsOR3KVuMOva2O/3k2OW7i2rSbsFnYIx0Z6GpSxBrZF8DOXUxUZuJ1AmqASU5qsyh8lOBf7OHwpPXZvOwoi/XfLl0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(39850400004)(366004)(136003)(376002)(396003)(346002)(451199015)(122000001)(41300700001)(26005)(71200400001)(9686003)(6506007)(7696005)(38100700002)(8676002)(86362001)(64756008)(76116006)(6916009)(66556008)(66476007)(66946007)(52536014)(66446008)(33656002)(38070700005)(83380400001)(186003)(316002)(55016003)(966005)(478600001)(8936002)(44832011)(2906002)(5660300002)(4744005)(46492015)(4628625004)(19623455010)(10090945012); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Um9JFIbDopTso+1b9Y081GiS/IKQC3SRoGyuzy8eB5FfLJ+gxvDI2u6fjB?= =?iso-8859-1?Q?nWXFUOGQdl3KXtaQgTp+BTM9w2yeifGWEMX+vJNwziUK6GbFKjuCsmsgsy?= =?iso-8859-1?Q?cc1ElUesYzSZMLAmfnDvrAbrBSrI5lx++U1VEFFC+gRrx3d0IdM2Q8rVFQ?= =?iso-8859-1?Q?nZKf2XbVavvTBmj2js1TLZnUEim4yzfm/pyFVzUdR1VBBlhevKbn4cMi16?= =?iso-8859-1?Q?zYUMCY75jKPTcQ1L3tK1CemoQY18iTRiKZle05Uy2m2NTu3qFzrmMf+Aza?= =?iso-8859-1?Q?GNMFkSPXWb1CZA8oAwezL3mY4thHVYqGPDI4og2dy7YqWigJ2lyGL1/No9?= =?iso-8859-1?Q?uS5vVp8sQ4m36cIkrEjKA54pJIqvpZ6GLqowX7hnmfRw2A2l/p0NuTNqGo?= =?iso-8859-1?Q?wXtxuRcrUq1Y+rvyn4otVSoSoQfYjC0+U4f33Of76Kwg983Q0klnZVWrpP?= =?iso-8859-1?Q?x6PItzYDF4w1PcPp8YsidfSHxX6H+8uLP7G4GXVzwZn+sPM2MVAkrf1kWj?= =?iso-8859-1?Q?vPBFUYXkdOfWTDDQdJsUE5viy2E3NOhdea6qBXWPHt5UXg5ghhFn7MW+eX?= =?iso-8859-1?Q?t+1oNO1sYsDsruMIfmP/OmQlSJXgBmbi3eOs2L6wTjfpcvWRLMIcOYrPKf?= =?iso-8859-1?Q?f/y9yspg6RX3VX6djyVAp01o5jpLw8Z08JmwqHSQUYrV9JRptSSrIJMqfO?= =?iso-8859-1?Q?jQCbBN85Ca60D1XhTWYkkcDW07BdrV2EQ4HWCMgUFRU1KfIxnh7TO+AD79?= =?iso-8859-1?Q?eyi7CtEo22O8b82iAEedTy0qvpnyr5HCY0hRGr4zLW0LVDdk+Qooh4iVrk?= =?iso-8859-1?Q?ANJBOq/CMoV9pKxYFG/QADvGBnbiiCiWtPassQOGOaX+cp9/H1h/edoOuQ?= =?iso-8859-1?Q?ti5ETpAQ01ZyQyroWWrZDMO0mpU8v+b6ZGqg4fZEHQVxep7aM6P9kHcHeL?= =?iso-8859-1?Q?Kkwdz6yn+0knmFlDQvugIM/fgpxCYnOBuxxoV+yapc6q5l7JhqPojUNf3H?= =?iso-8859-1?Q?aBKpuyPkNOChw0/pkTTvgz3+au6oVJBiuGHqM4VAXRm9laxJerNHeFGCcj?= =?iso-8859-1?Q?lIChVbNnrefDSjz2H8sbKQsa6X9thgFnBS6SLdGNtSseCqbBuLssF9DH2M?= =?iso-8859-1?Q?orPIHUYji1zs8VP2yt9H2feH+/IK87jnNkzjHR6YxPM9+6TWjdb++ZmbZU?= =?iso-8859-1?Q?5xItbUjgdsePfKYvA7PrtuzZ069ZubKSSIOkZ1lCVqjfLW5Pmrj/V75OYL?= =?iso-8859-1?Q?OJIhG9yi8vNNcqpjHnvtJQDjK2Mae1SNxm5ZR8vFktZYghx7yLe+bGcm2W?= =?iso-8859-1?Q?u3TWaI+fUEjC9dOV81ST5PVZvds+MMrSY8cNHuzfgeG7zR0k427YOvwS7Y?= =?iso-8859-1?Q?HVYIqWUa+83LNQMunAbdKS8+CSVCok7CNi5eeJCwW/wD6L80k31LXd3wm3?= =?iso-8859-1?Q?yBWSBXUpRyvIturdjikjifXMVVYbdUk53xK4bonla0Sjspud4BeGEOh67Q?= =?iso-8859-1?Q?712uT2KECfNKWGIWuu+I68TLLUM1GtDOSNkjGJuAdwjm0lHQ91uMuj/5g6?= =?iso-8859-1?Q?9b4tJ4PPQ0a/GBQdX2lhsVWBbZmgwD9Btgwn+16xwZRzdObf0hfbA27yYa?= =?iso-8859-1?Q?cEx6iznjMHQAQ54YMeQ2JVInh7ON9On5hb?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f504659f-4441-48e0-ae0b-08da97bd782a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2022 08:28:44.6553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4sBcIcRVkkn2CGh6q2rFU6CaQOP2D3vGtbsy96uc3Kx/xpcCMSea944rhrCJWHqj69TSP+9bgSFEKfmwxTkKCmGjVDqj5l5rbUmVeMCIDXU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB2882 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >Envoy=E9=A0: mardi 13 septembre 2022 23:31 >Mantissas are the last data in the channel subsegment and it appears it is= sometimes missing a very few bits for the parsing to complete. >This should not be confused with data corruption. Here is a very short sample set with an audacity screen grab which shows th= e effect of the fix: http://0x0.st/oOvv.zip I don't know how to make this patch acceptable... and especially I understa= nd that setting an arbitrary limit with a #define does not look to be the b= est practice in the world. The fact is that the reference implementation (checked against dp600 and a = certified broadcast encoder) does handle that (maybe with no limit at all, = hard to tell). Do you have any suggestion ? If it can help, I can post a message to ffmpeg-user to gain more users supp= ort ? Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".