From: Nicolas Gaullier <nicolas.gaullier@cji.paris>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits
Date: Fri, 16 Sep 2022 08:28:44 +0000
Message-ID: <MR1P264MB2483C7A6FBB710F186A3D7B39B489@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220913213127.1756-1-nicolas.gaullier@cji.paris>
>Envoyé : mardi 13 septembre 2022 23:31
>Mantissas are the last data in the channel subsegment and it appears it is sometimes missing a very few bits for the parsing to complete.
>This should not be confused with data corruption.
Here is a very short sample set with an audacity screen grab which shows the effect of the fix:
http://0x0.st/oOvv.zip
I don't know how to make this patch acceptable... and especially I understand that setting an arbitrary limit with a #define does not look to be the best practice in the world.
The fact is that the reference implementation (checked against dp600 and a certified broadcast encoder) does handle that (maybe with no limit at all, hard to tell).
Do you have any suggestion ?
If it can help, I can post a message to ffmpeg-user to gain more users support ?
Nicolas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-16 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 21:31 Nicolas Gaullier
2022-09-16 8:28 ` Nicolas Gaullier [this message]
2022-10-14 8:03 ` Nicolas Gaullier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MR1P264MB2483C7A6FBB710F186A3D7B39B489@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM \
--to=nicolas.gaullier@cji.paris \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git