From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C563642810 for ; Fri, 1 Apr 2022 07:05:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BBB268B221; Fri, 1 Apr 2022 10:05:41 +0300 (EEST) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-eopbgr120041.outbound.protection.outlook.com [40.107.12.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2157768B1AC for ; Fri, 1 Apr 2022 10:05:34 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZh8P7+UWqua3KeYWTF86uEHh8SiqpOGYyRZFKc9Qkfe7HP0gi9aGppGkwpVM4QcCe05BHFpqJerTpLQer9q0t6sf5tjPjaXKLq5z9TX+txu1wOBQivwDH5R4WT3UbfPkdl/J19Jtr9wz2G9ezJY+ZhuPsYrXF03IxTPSC55VRvdv77F01oVK1SSJtwtEVo6fEpNNJts2uT9nijoTdxZYXVxSR8M44QlbvebhVSafWP0TuUT+AMCBmHBI35lgkvV7eh59rXnC9QeYZwGzdTW+jTO0LS9t/fEQ8Di+WPFwBOOrY1RppKsqFUrA4qBXNHtodsAFPTq9+4DmdGhSepWYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2rpAbjTIlLwdvWq7jKfufL6j1cPf6kNKrsZxW1I6RGk=; b=Po/ckOGP+YHOeVVW5yG1I2hGuWS2rJGaMd2hs/uMOr13yQMiMK0rRaP3VoLamdhPVQokxqeWYGK9yzFjJfMXTcPyzcUKLuWy1qbA688Pi6N0LmfDALVNb0VRGkfiw4xxPC+dm6qO6g8/8py+HNT60XH+kNwGKq6fK7NTGWXbjSR8qsO0xVnCBNCvfFUrp4WlhswUYphReBdKyAJRG6E00a9o54M4zb1ctoFN18gRXu2i+/O8PaHFgPXSeD5lIkC8jXVB1Jv1NS9YCQTOkhLeZnNUOZgL4hFjtbXaXj4w+QsyyW7XSJJfUJl9DQa2XXkB36whapE8B8PcuBPV7jY20g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2rpAbjTIlLwdvWq7jKfufL6j1cPf6kNKrsZxW1I6RGk=; b=HvgsgteRycS28CUG/YaGCNKpQrFcy2mp2YkY/vVo999GU37qgAoX+0ZtFjNthualb4cFyD6Un3/7Ym4L5Bqsw7uyr4iIf0+tuMxsZhC1SJbYD24SrFAvfSKLA50w1QthtKtRtN33MfFi6UAa+X18Jv6Gsj5tt2/VPMDAyKeK7fT2KKy9XP+0EZvwqdErE82S9Z+ZVdUnZLq1DBc/FfYTFv3LWIu2hV9VZHKItE/ZEis63nsAyNWb5eFL8UF5JnUmXz6NH2+krLKtOCEcwKhLyz7Pwvnb1vDuNUIs5QLV3bbPJhlFy1pyCEQGIZdldzlBBgSagTlMFMdDE/sy3yOyGQ== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by PAZP264MB2685.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1f6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.25; Fri, 1 Apr 2022 07:05:31 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::cde:406:661f:1762]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::cde:406:661f:1762%6]) with mapi id 15.20.5123.025; Fri, 1 Apr 2022 07:05:31 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 2/2] lavf/mpegenc: fix termination on error conditions Thread-Index: AQHYQJtdxY3deI6cy0GXww+GmdmpKqzaKNiAgACAqoA= Date: Fri, 1 Apr 2022 07:05:31 +0000 Message-ID: References: <20220325225452.47-1-nicolas.gaullier@cji.paris> <20220325225452.47-3-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86119ad0-bf91-44de-ce1f-08da13ae0272 x-ms-traffictypediagnostic: PAZP264MB2685:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PA+OdZiz4vWqeU/h30RC1rMf7IBu+7eOolbcqpS3VOUFcBvExETOnRrYsyMBtrgjMQIAHGYofbFXp1jFxCloqlYfdzk4FIzaDrDiDTqKWRGVu9m9YEebZnBbHbjE9q1FuuVvweAAT+dtxk79KVsg8GC/R+LLraJvYZak5vPLU4Eb3g5FYd5hN6CJL4Yl4zCVQuJiQ3SRl+jFBhWeShnnSvX0VpDTTYPc0d2cULIYsKIVlXD+H2o3dW4ZKa2QA2oINqlKj1SUZ0RQ9++jHjDXbBY8c3FNdGPg1AKQeqnJr5+/waTJ8jA8NJJi3FS9d6QuDvTz4DYeXei97TczgAp/bxnDBzZFKRDz4QM2yFVlaL7ytVyEEeSI+2tZL3ebU7J4pPhHoIDiVSequbYV7wcvMTeEViVpYJoWN69XANqTVmn2pgv5qm31XYdtwYE/49tfOJp8+/ESbXVol6quIedGIR0GDIikW9zikSit9Msq8nSx6/crLbLlmyAq3qmPvQEIIEkxIW6tJzqClIeCmmF8IjdWXLUVDFu1rpisfEWQA6e37Nhcku6ytJJrW7Awpn97JPELKOkuy3LQnPVkGq0Ho2v1bJbzaRUo9f5zyld7TzO0YhYunfzbRn9CW0FVYtIRGgf4UYu7+cqh+IFsgx1oC2ALNEdEjJc2aQ7ysUekNpDL7mlY793pZy2gQWL0FpCGt5QpuyeRevq92krR5RIKOjirHYfOxIS+Y5z7rgskdQo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(122000001)(55016003)(38100700002)(33656002)(5660300002)(44832011)(52536014)(7696005)(6916009)(76116006)(66946007)(8936002)(186003)(26005)(38070700005)(86362001)(66476007)(8676002)(6506007)(9686003)(4744005)(498600001)(66446008)(71200400001)(66556008)(64756008)(46492015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zSU+4Xwt16wBBzDA2dcqCuUlr/UAmqKoCGm1qast4PaeoOZHM30Nu/sTT0qn?= =?us-ascii?Q?EPSE7DzCWYTu6Oodch1Elvn1EdEs9d4u4cR40m2b9E1DLxApIU5Fd9XYFVXF?= =?us-ascii?Q?kV7bzXpdcmzKooZgl7MgsnQupwhnDzfEChDZhvklPb7sKCzAcXvy8z8Yr20Z?= =?us-ascii?Q?vKuvMVuTKBw/h8iSf3XzXIyW0lAkvcd6OjPqSX3i48y3U5gYNwJAJiB6r+nQ?= =?us-ascii?Q?gHI0ZlXjoSz4b8SUowooghtFjjfB1XVB9NOxBOtwHFbV6eh/33wFlN8YYETT?= =?us-ascii?Q?lMNO2GQ8E4y7fc5OIRyfFG3e3Yexl0Z4aN3p2XYBuwLj6XmROk/ms4w40dRf?= =?us-ascii?Q?8+6u9eQAQ6LDDVkrp+7Qs29X3ra/nGtQY45vZ5jmhj0wBybQj+BiLTtWPeN/?= =?us-ascii?Q?zmsqRHKS8RrLIQzw5VWEJW8H3YPgIYymKl8aokPKDC+K4BoZUeQlipTrnsX5?= =?us-ascii?Q?8zL8v7R2EoAyWUxZJYp88dXuIAQCquJ6+9mA2VjQ4PAdBBkm7JpDxO6ZvpLi?= =?us-ascii?Q?uzmyfmv8j7Kuw9L7Pl2WTeb7HV8UhvwQ8qZR0jkMwGo/CrYkb1gplxdCK3LL?= =?us-ascii?Q?mWFnTb7lraXxm5mugFzZ04aasq1dKQYG5I7x0nSniSM7BP5+tcamK4+E2Uz4?= =?us-ascii?Q?CfgLsd4bRAkRTPTa+rBhaMZwPMMd6NCvh27j4V4Mz7Kxv3SPBR/ArQAEmn8N?= =?us-ascii?Q?yfelk0sm/A0RD5qwmMWvvhOkZO9l+ceOcG5zl3e06ZVAOMmkpJg52KG5QloF?= =?us-ascii?Q?GfXUayR2PUj1FBpfGg+65CgaSWtj5/qoiF3JN0sDaxPkBYXQnxm/q5r3yfIS?= =?us-ascii?Q?W/cHkuzXWx1zsJlCgoJR4sG5zYRC8a1kpU9BeBAizL2km/QQxt/Sw/iAJm7V?= =?us-ascii?Q?HN6U4NQwzB5UqoqhKTTob5SoM/5HEEh7my5WOPFtEvQE3P820X8S4ReAwLtH?= =?us-ascii?Q?xfNAOg++SdNJiTYvFGCCgrf3+xHUoEluFM5rIF6UIXZTrzMCeX7fclXOs3l/?= =?us-ascii?Q?nkbMqCyDtm6vKG0ph3JuC6zKHimlSggW/CSTXNma52GM0MYvZwbikBplxCeC?= =?us-ascii?Q?cEMQAY8N+Dk8ybNMTnl+8ShpjDHB8qFv1CH3QA5T1F4FOFkAEFsECR6MfMXD?= =?us-ascii?Q?p9+riost9W663EpH2+u99ExzGc6n01TVQtxwCvktFt3R88EUZrxGTAEGIYr8?= =?us-ascii?Q?4ezYsPGURjFkLH5YkOkQBykhJzkKyLkOguOVG4KJ80py2SatNesZ8Pcxj0x3?= =?us-ascii?Q?cm4M25C1EIV3uj3Y1mFV2/imRaNNesFH+1SgVKKaVU4sUp0vosmVDvDFCA+J?= =?us-ascii?Q?pjN8VgQnQrO0SqmgjlqunPsOsq8c2SQoY0723mVChK7ePWmeqUzKy6dB3Ctd?= =?us-ascii?Q?KZx/A/HyoYwYEKK2mWwdGvGRDnouVUeYVuRfM0dSTJdQ9UzJQdMuxnS5r+wO?= =?us-ascii?Q?tlkgM8ftYIg8PgmV6xh+XUABwq8Mk77oNZHinOkWA4lwKcQj8nVfIsuC3ume?= =?us-ascii?Q?Q3cmq4BJ4bOg6Q5iCRc/3uvSlJ5h0GE9qcH/ZZvZQj1Hm9h0ouiID4zlD+l+?= =?us-ascii?Q?ENxIj5bCETWlk6C9kXa1xYgZle0J1RhARHM+esz9CC6k9w5E1xHL6RSIKaw5?= =?us-ascii?Q?c8/If41BgNWApsbg6X5IzXxQNUbvGdu34y6CNQbe2CfVU9h8Ragq6Yq21xvE?= =?us-ascii?Q?mAR0YxS/CS+GeYAUkLOiKOCyLNsSS8fOG0ds0fdU2QUuM6berScppWfOpoNs?= =?us-ascii?Q?dT3avr/34Q=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 86119ad0-bf91-44de-ce1f-08da13ae0272 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 07:05:31.2193 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pN6drbWuTRzNsB5LfNjRzStEkpBaXbpyqqC+1wmtbDmBj6lHyxNVkqtWRWOsG4t2Mo072F1SenqC/GALqKhqmLve436ORzqgxgYXVtMWY9E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAZP264MB2685 Subject: Re: [FFmpeg-devel] [PATCH v5 2/2] lavf/mpegenc: fix termination on error conditions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >in case of errors, the context is left in an inconsistent state: The PacketDesc linked-list claims that there is data in the FIFO although this is wrong. I always prefer avoiding such scenarios over fixing them lateron. In this case, fixing them would mean growing the FIFO before >allocating the new PacketDesc (if the FIFO needs growing at all). Shall I do this or do you want to? >(In any case, thanks for reporting this issue.) > >- Andreas I fully understand. I think the most time-effective is to let you do that if you are ok, you also know this code better than me. Thanks to you Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".